Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed data #407

Merged
merged 7 commits into from
Feb 21, 2024
Merged

Seed data #407

merged 7 commits into from
Feb 21, 2024

Conversation

alexwolfmsft
Copy link
Contributor

@alexwolfmsft alexwolfmsft commented Feb 21, 2024

Summary

Describe your changes here.

Fixes #Issue_Number (if available)


Internal previews

📄 File 🔗 Preview link
docs/database/seed-database-data.md Seed data in a database using .NET Aspire

@dotnet-bot dotnet-bot added the database Content related to database. label Feb 21, 2024
@alexwolfmsft alexwolfmsft marked this pull request as ready for review February 21, 2024 16:38
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you. We'll :shipit: when you make the suggested changes.

docs/database/seed-database-data.md Outdated Show resolved Hide resolved
docs/database/seed-database-data.md Show resolved Hide resolved
@IEvangelist
Copy link
Member

Do you think that this PR covers this issue #64?

@alexwolfmsft
Copy link
Contributor Author

Do you think that this PR covers this issue #64?

I think it partially answers it - it sounds like in #64 they are trying to do traditional "Design time" migrations where they can just run migrations against their database or container using the ef core tools regardless of whether the app is running. However, the database container either doesn't exist or isn't accessible from local ef core tooling, which is why the example runs them during startup. I think this new doc shows them an alternate way of doing this, which they might be interested in - I don't think .NET Aspire supports traditional design time migrations at this point.

@alexwolfmsft alexwolfmsft merged commit faa6f19 into dotnet:main Feb 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database Content related to database.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants