Skip to content

Conversation

@DennisLee-DennisLee
Copy link
Contributor

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @DennisLee-DennisLee. As usual, see my comments before we merge this.

@DennisLee-DennisLee DennisLee-DennisLee changed the title 1436790/1438462: Part 12: 20 files with MSDN link fixes. 1436790/1438462: Part 12: 17 files with MSDN link fixes. Feb 7, 2019
Accepting Maira's committable suggestions. Will review the rest after PR dotnet#10330 is merged.

Co-Authored-By: DennisLee-DennisLee <[email protected]>
@mairaw
Copy link
Contributor

mairaw commented Feb 7, 2019

@DennisLee-DennisLee now that I merged Part 11, we got merge conflicts. Can you resolve them? Thanks.

@DennisLee-DennisLee
Copy link
Contributor Author

@mairaw I think I've addressed everything in this and part 13 (PR #10351).

@DennisLee-DennisLee DennisLee-DennisLee changed the title 1436790/1438462: Part 12: 17 files with MSDN link fixes. 1436790/1438462: Part 12: 15 files with MSDN link fixes. Feb 7, 2019
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DennisLee-DennisLee! 👍

@mairaw mairaw merged commit f1e157c into dotnet:master Feb 7, 2019
@mairaw mairaw added this to the February 2019 milestone Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants