-
Notifications
You must be signed in to change notification settings - Fork 6k
SEOImages: User Story 1463880, Part 14 #11333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c4b23e4
Image updates.
damabe a9fd7be
Image updates.
damabe 648a692
Merge branch 'master' of https://github.com/dotnet/docs
damabe ad6b189
Merge branch 'master' of https://github.com/dotnet/docs
damabe 3b1be9a
Merge branch 'master' of https://github.com/dotnet/docs
damabe 970c319
Merge branch 'master' of https://github.com/dotnet/docs
damabe 1531b8d
Merge branch 'master' of https://github.com/dotnet/docs
damabe 3ba1a22
Merge branch 'master' of https://github.com/dotnet/docs
damabe f170c87
Merge branch 'master' of https://github.com/dotnet/docs
damabe 78f0a47
SEO image updates.
damabe c249498
SEO image updates.
damabe 5d131eb
Reviewer feedback.
damabe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this sentence to a paragraph before the image like
"The following image shows..."
Otherwise, only screen readers will have this info.
The alt text could say Screenshot of Trace Viewer showing [WCF client activities listed by creation time.
Apply same feedback to the other images here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made this change. Will apply to other images here (and other PRs, as needed). On the alt text, if I add the text as you recommend, it ends up higher than the 70 character threshold. I modified to be <70. Please review and let me know if it is OK.