Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete orphaned markdown files #15561

Closed
wants to merge 3 commits into from
Closed

Conversation

gewarren
Copy link
Contributor

Contributes to #15560

@mairaw
Copy link
Contributor

mairaw commented Oct 30, 2019

We shouldn't delete those files. @BillWagner probably knows best the plan for the error messages in C#.

@mairaw
Copy link
Contributor

mairaw commented Oct 30, 2019

Some might be not in TOC by accident (like I see some in framework/additional-apis). Content in that folder should never be deleted because they are added because of compliance issues.

For framework/misc, these were security topics that were not added by the TOC by design. I had a plan to move them to standard/security and perhaps add them to the TOC under a legacy node or something. I'd recommend that we close this PR and discuss the plan.

@gewarren
Copy link
Contributor Author

Some might be not in TOC by accident (like I see some in framework/additional-apis). Content in that folder should never be deleted because they are added because of compliance issues.

For framework/misc, these were security topics that were not added by the TOC by design. I had a plan to move them to standard/security and perhaps add them to the TOC under a legacy node or something. I'd recommend that we close this PR and discuss the plan.

Okay, I'll close it. At least we have a list to work off of.

@mairaw
Copy link
Contributor

mairaw commented Oct 30, 2019

Indeed. I think it's good to have the list!

@BillWagner
Copy link
Member

For the csharp/misc folder: The long term plan is to keep these, and not have them in the TOC. They should be found only by search by error code.

@gewarren Is there a way to ignore a specific folder with the clean-repo tool? All these files are in two folders (csharp/misc and csharp/language-reference/compiler-messages)

@gewarren
Copy link
Contributor Author

For the csharp/misc folder: The long term plan is to keep these, and not have them in the TOC. They should be found only by search by error code.
@gewarren Is there a way to ignore a specific folder with the clean-repo tool? All these files are in two folders (csharp/misc and csharp/language-reference/compiler-messages)

@BillWagner There is not currently that functionality, but it's easy enough to revert changes to files in specific folders after running the tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants