Skip to content

Update dotnet run for 3.0/3.1 #15657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 19, 2020
Merged

Update dotnet run for 3.0/3.1 #15657

merged 5 commits into from
Feb 19, 2020

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Nov 2, 2019

As I've been updating the CLI docs, I've been removing the tabs and combining all the content into a single view. Also added the default value for the verbosity option and changed the config param to allow other values besides Debug and Release.

Internal review URL

Contributes to #9373

@mairaw mairaw added this to the November 2019 milestone Nov 2, 2019
@mairaw mairaw requested review from dsplaisted and sfoslund November 2, 2019 01:27
@mairaw mairaw self-assigned this Nov 2, 2019
@tdykstra
Copy link
Contributor

@mairaw is this ready to merge if I address the comment about -r being introduced in 3.0?

@mairaw mairaw requested a review from tdykstra as a code owner February 19, 2020 21:02
@mairaw
Copy link
Contributor Author

mairaw commented Feb 19, 2020

@tdykstra I think this one is good to go now. I'm going trough my open PRs to see what still needs work.

@mairaw mairaw modified the milestones: November 2019, February 2020 Feb 19, 2020
@mairaw mairaw changed the title remove tabs and change formatting Update dotnet run for 3.0/3.1 Feb 19, 2020
@tdykstra
Copy link
Contributor

Thanks. Could you check #15694 too?

@tdykstra tdykstra merged commit 1812cdc into dotnet:master Feb 19, 2020
@mairaw mairaw deleted the dotnet-run branch February 19, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants