Clarified where to make the test folder #17112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you make the `test` folder in the `src` folder then the paths are wrong in the xml
|
|
tdykstra
reviewed
Feb 28, 2020
There was a problem hiding this comment.
@meeple142 Thanks for this correction -- please click the CLA "sign now" link so we can merge this PR, and take a look at my suggested change.
| @@ -97,7 +97,25 @@ Optional exercise: You can add a new pet type, such as a `Bird`, by extending th | |||
|
|
|||
| The `NewTypes` project is in place, and you've organized it by keeping the pets-related types in a folder. Next, create your test project and start writing tests with the [xUnit](https://xunit.github.io/) test framework. Unit testing allows you to automatically check the behavior of your pet types to confirm that they're operating properly. | |||
|
|
|||
| Navigate back to the *src* folder and create a *test* folder with a *NewTypesTests* folder within it. At a command prompt from the *NewTypesTests* folder, execute `dotnet new xunit`. This produces two files: *NewTypesTests.csproj* and *UnitTest1.cs*. | |||
| Navigate back to the *root* folder and create a *test* folder with a *NewTypesTests* folder within it. | |||
There was a problem hiding this comment.
Suggested change
| Navigate back to the *root* folder and create a *test* folder with a *NewTypesTests* folder within it. | |
| Navigate back to the *NewTypes* folder and create a *test* folder with a *NewTypesTests* folder within it. |
Thraka
added
the
✨ 1st-time docs contributor!
|
@meeple142 please click the CLA "sign now" link so we can merge this PR. |
|
closing due to lack of response. @meeple142 If you want us to merge this, please re-open, sign the CLA, and respond to the review suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If you make the
testfolder in thesrcfolder then the paths are wrong in the xml.This is linked to #11866
I think they updated the paths but not the directions.