Skip to content

Conversation

jameshkramer
Copy link
Contributor

This PR is for user story #1576037.

It adds four article files, makes corresponding deletions from the C# and VB folders, and adds redirection entries. It also fixes a few article files from previous commits, and fixes a few redirection entries..

Please merge #17846 and #17892 before merging this.

cc: @tfosmark @marteeleigh

Contributes to #4728

@dotnet-bot dotnet-bot added this to the April 2020 milestone Apr 18, 2020
@jameshkramer jameshkramer force-pushed the br24-add-topic-files-67-to-70 branch from 0509b79 to 1a4e093 Compare April 18, 2020 00:37
@BillWagner BillWagner requested a review from mairaw April 21, 2020 15:06
@BillWagner
Copy link
Member

Adding @mairaw, who has been following this.

@mairaw mairaw added the vendor-project Indicates the issue/pr is related to a vendor project. label Apr 26, 2020
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some comments for you to review before merging. It seems some of the files were also part of the other PRs?

@BillWagner BillWagner modified the milestones: April 2020, May 2020 Apr 28, 2020
@mairaw
Copy link
Contributor

mairaw commented Apr 28, 2020

Ping me when changes are applied and conflicts resolved @jameshkramer. Thanks!

@jameshkramer
Copy link
Contributor Author

@mairaw @BillWagner

Maira, I made the changes. There is still an unresolved conversation where I added a description.

@mairaw mairaw merged commit 026ecc6 into dotnet:linq-to-xml Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vendor-project Indicates the issue/pr is related to a vendor project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants