-
Couldn't load subscription status.
- Fork 6k
Desktop e-book #18425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Desktop e-book #18425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add chapter 1 * Update docs/architecture/modernize-desktop/why-modern-desktop-applications.md Co-Authored-By: Maira Wenzel <[email protected]> * Updated to 85 Acrolinx score * Apply suggestions from code review Co-Authored-By: Maira Wenzel <[email protected]> * Address comments and added Next button * Apply suggestions from code review Co-Authored-By: Maira Wenzel <[email protected]> * Removed question mark from the title Co-authored-by: Maira Wenzel <[email protected]>
* Add chapter 2 * Update Acrolinx score to 85 * Apply suggestions from code review Co-Authored-By: Maira Wenzel <[email protected]> * Address Maira's comments * Remove trailing space * Add Previous and next buttons * Removed whitespace * Apply suggestions from code review Co-Authored-By: Maira Wenzel <[email protected]> Co-authored-by: Maira Wenzel <[email protected]>
* small fixes * fix warnings
* Add --ResultsDirectory (#17818) * Add --ResultsDirectory * fix typo * add globbing pattern for windows (#17816) * Placeholder for Modernize eBook * --list-runtimes fix and run .dll note (#17814) * Link to resources for filter expressions (#17817) * Link to resources for filter expressions * Update docs/core/tools/dotnet-vstest.md Co-Authored-By: Genevieve Warren <[email protected]> Co-authored-by: Genevieve Warren <[email protected]> * Acrolinx 4/13 (#17821) * acrolinx * Apply suggestions from Tom Co-Authored-By: Tom Dykstra <[email protected]> * Placeholder for Modernize eBook * Apply suggestions from code review Co-Authored-By: Genevieve Warren <[email protected]> * Update docs/architecture/toc.yml Co-Authored-By: Genevieve Warren <[email protected]> * Apply suggestions from code review Co-Authored-By: Maira Wenzel <[email protected]> * Update links Co-authored-by: Tom Dykstra <[email protected]> Co-authored-by: Genevieve Warren <[email protected]> Co-authored-by: Maira Wenzel <[email protected]>
* Add chapter 3 * Replace numbers with chapter names * Update to 83 Acrolinx score * Apply suggestions from code review Co-Authored-By: Maira Wenzel <[email protected]> * Update migrating-modern-desktop-applications.md * Update migrating-modern-desktop-applications.md * Remove trailing spaces * Apply suggestions from code review Co-Authored-By: Maira Wenzel <[email protected]> * Address comments * fix linting errors * add missing comma Co-authored-by: Maira Wenzel <[email protected]>
* Add chapter 4 * Replace numbers with chapter names * Update to 86 Acrolinx score * Apply suggestions from code review Co-Authored-By: Maira Wenzel <[email protected]> * Address review comments * Apply suggestions from code review Co-Authored-By: Maira Wenzel <[email protected]> * Add Previous and Next buttons * address review comments * fix linting error Co-authored-by: Maira Wenzel <[email protected]>
* update outdated paragraph * use non-fixed path
* Add chapter 5 * Replace numbers with chapter names * Update to 80 Acrolinx sroce * Apply suggestions from code review Co-Authored-By: Maira Wenzel <[email protected]> * Address Maira's comments * rename file * Revert "rename file" This reverts commit 30ae1a4. * update per Maira's comments * fix img names * use standard paragraphs * fix warnings * Apply suggestions from code review Co-authored-by: Maira Wenzel <[email protected]> * fixed links Co-authored-by: Maira Wenzel <[email protected]>
* Add chapter 6 * Replace numbers with chapter names * Updated to 85 Acrolinx score * Apply suggestions from code review Co-Authored-By: Maira Wenzel <[email protected]> * Address Maira's comments * use standard paragraph * use standard paragraph * Apply suggestions from code review Co-authored-by: Maira Wenzel <[email protected]> * Address review comments * fix image path * fix typo * fix img path Co-authored-by: Maira Wenzel <[email protected]>
* Desktop book updates * fix brand
* Moved some parts from Chapter 1 to * Updated cover * expand titles + feedback + typo * add formatting * more formatting Co-authored-by: Maira Wenzel <[email protected]>
nishanil
approved these changes
May 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OliaG
approved these changes
May 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't squash and merge this PR
@nishanil feel free to merge when you're ready to ship it!