Skip to content

Conversation

@mairaw
Copy link
Contributor

@mairaw mairaw commented May 14, 2020

Don't squash and merge this PR

@nishanil feel free to merge when you're ready to ship it!

OliaG and others added 18 commits April 13, 2020 20:09
* Add chapter 1

* Update docs/architecture/modernize-desktop/why-modern-desktop-applications.md

Co-Authored-By: Maira Wenzel <[email protected]>

* Updated to 85 Acrolinx score

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <[email protected]>

* Address comments and added Next button

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <[email protected]>

* Removed question mark from the title

Co-authored-by: Maira Wenzel <[email protected]>
* Add chapter 2

* Update Acrolinx score to 85

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <[email protected]>

* Address Maira's comments

* Remove trailing space

* Add Previous and next buttons

* Removed whitespace

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <[email protected]>

Co-authored-by: Maira Wenzel <[email protected]>
* small fixes

* fix warnings
* Add --ResultsDirectory (#17818)

* Add --ResultsDirectory

* fix typo

* add globbing pattern for windows (#17816)

* Placeholder for Modernize eBook

* --list-runtimes fix and run .dll note (#17814)

* Link to resources for filter expressions (#17817)

* Link to resources for filter expressions

* Update docs/core/tools/dotnet-vstest.md

Co-Authored-By: Genevieve Warren <[email protected]>

Co-authored-by: Genevieve Warren <[email protected]>

* Acrolinx 4/13 (#17821)

* acrolinx

* Apply suggestions from Tom

Co-Authored-By: Tom Dykstra <[email protected]>

* Placeholder for Modernize eBook

* Apply suggestions from code review

Co-Authored-By: Genevieve Warren <[email protected]>

* Update docs/architecture/toc.yml

Co-Authored-By: Genevieve Warren <[email protected]>

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <[email protected]>

* Update links

Co-authored-by: Tom Dykstra <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>
Co-authored-by: Maira Wenzel <[email protected]>
* Add chapter 3

* Replace numbers with chapter names

* Update to 83 Acrolinx score

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <[email protected]>

* Update migrating-modern-desktop-applications.md

* Update migrating-modern-desktop-applications.md

* Remove trailing spaces

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <[email protected]>

* Address comments

* fix linting errors

* add missing comma

Co-authored-by: Maira Wenzel <[email protected]>
* Add chapter 4

* Replace numbers with chapter names

* Update to 86 Acrolinx score

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <[email protected]>

* Address review comments

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <[email protected]>

* Add Previous and Next buttons

* address review comments

* fix linting error

Co-authored-by: Maira Wenzel <[email protected]>
* update outdated paragraph

* use non-fixed path
* Add chapter 5

* Replace numbers with chapter names

* Update to 80 Acrolinx sroce

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <[email protected]>

* Address Maira's comments

* rename file

* Revert "rename file"

This reverts commit 30ae1a4.

* update per Maira's comments

* fix img names

* use standard paragraphs

* fix warnings

* Apply suggestions from code review

Co-authored-by: Maira Wenzel <[email protected]>

* fixed links

Co-authored-by: Maira Wenzel <[email protected]>
* Add chapter 6

* Replace numbers with chapter names

* Updated to 85 Acrolinx score

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <[email protected]>

* Address Maira's comments

* use standard paragraph

* use standard paragraph

* Apply suggestions from code review

Co-authored-by: Maira Wenzel <[email protected]>

* Address review comments

* fix image path

* fix typo

* fix img path

Co-authored-by: Maira Wenzel <[email protected]>
* Desktop book updates

* fix brand
* Moved some parts from Chapter 1 to

* Updated cover

* expand titles + feedback + typo

* add formatting

* more formatting

Co-authored-by: Maira Wenzel <[email protected]>
@mairaw mairaw requested review from a team and nishanil as code owners May 14, 2020 01:13
@dotnet-bot dotnet-bot added this to the May 2020 milestone May 14, 2020
@mairaw mairaw requested a review from OliaG May 14, 2020 01:14
Copy link
Member

@nishanil nishanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @OliaG and @mairaw for the awesome work!

Copy link
Contributor

@OliaG OliaG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nishanil nishanil merged commit 75b2080 into master May 14, 2020
@nishanil nishanil deleted the desktop-ebook branch May 14, 2020 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants