Skip to content

Conversation

@jameshkramer
Copy link
Contributor

This PR is for user story #1576037.

It adds four article files, makes corresponding deletions from the C# and VB folders, and adds redirection entries. It also provides fixes to toc.yml and some article files.

Please merge #18299, #18325, #18413, #18439, #18541, #18580, and #18589 before merging this.

cc: @BillWagner @mairaw @tfosmark @marteeleigh

Contributes to #4728

@dotnet-bot dotnet-bot added this to the May 2020 milestone May 28, 2020
@mairaw mairaw added the vendor-project Indicates the issue/pr is related to a vendor project. label May 28, 2020
@BillWagner BillWagner modified the milestones: May 2020, June 2020 Jun 4, 2020
@jameshkramer jameshkramer force-pushed the br38-add-topic-files-119-to-122 branch from 4ddf446 to a80895a Compare June 10, 2020 17:08
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave this a quick look, and it looks good. Once the conflicts are resolved, I'll do a more thorough review and merge it.

Thanks again @jameshkramer

@mairaw
Copy link
Contributor

mairaw commented Jun 19, 2020

@jameshkramer can you resolve the merge conflicts here?

@jameshkramer
Copy link
Contributor Author

@mairaw @BillWagner

I resolved the conflicts - Jim

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but left some suggestions for some improvements

@jameshkramer
Copy link
Contributor Author

@mairaw @BillWagner

Maira, I made the changes you requested - Jim

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants