Skip to content

Conversation

bradriske
Copy link
Contributor

Summary

Following the same thought and changes from pull request #18691 updated the use of .NET Framework to just .NET anywhere that wasn't explicitly referencing the Framework itself or a comparison to .Net Core. Additionally updated several references to "framework version x.x or newer" to say "framework version x.x or higher" to be consistent with other places this is used.

Contributes To #18697

Change newer to higher on versions for consistency
@dnfadmin
Copy link

dnfadmin commented Aug 13, 2020

CLA assistant check
All CLA requirements met.

@@ -1,13 +1,13 @@
---
title: "Introduction to the C# Language and the .NET Framework"
title: "Introduction to the C# Language and .NET"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This article needs to be reviewed carefully to make sure the information provided in it are not .NET Framework-specific. Then it may be worth renaming the file and adding a redirection.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BillWagner This is an ancient intro to C#. My inclination is to retire it and redirect to the new Tour of C#. What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's on my plan for part of this release cycle (probably next month).

@BillWagner BillWagner added the ✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository label Aug 13, 2020
@BillWagner BillWagner requested a review from tdykstra August 13, 2020 15:32
@BillWagner
Copy link
Member

I requested an additional review from @tdykstra

He's been maintaining our glossary, and it would be good to have him give this a close look 🔎

Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some cases, especially in link text when linking to a doc that (still) has Framework-specific content, dropping "Framework" after ".NET" could be misleading. Within docs that have Framework-specific content, dropping "Framework" is usually not as likely to result in misunderstanding. It's not always obvious what is the best choice in each instance, but I made some suggestions where I thought Framework should remain.

@@ -1,13 +1,13 @@
---
title: "Introduction to the C# Language and the .NET Framework"
title: "Introduction to the C# Language and .NET"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BillWagner This is an ancient intro to C#. My inclination is to retire it and redirect to the new Tour of C#. What do you think?

- You passed a variable name to the [typeof](../operators/type-testing-and-cast.md#typeof-operator) operator.

- You tried to reference an assembly that is not part of your target .NET Framework profile. For more information, see [Troubleshooting .NET Framework Targeting Errors](/visualstudio/msbuild/troubleshooting-dotnet-framework-targeting-errors).
- You tried to reference an assembly that is not part of your target .NET profile. For more information, see [Troubleshooting .NET Targeting Errors](/visualstudio/msbuild/troubleshooting-dotnet-framework-targeting-errors).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content of the referenced doc is Framework-specific.

Suggested change
- You tried to reference an assembly that is not part of your target .NET profile. For more information, see [Troubleshooting .NET Targeting Errors](/visualstudio/msbuild/troubleshooting-dotnet-framework-targeting-errors).
- You tried to reference an assembly that is not part of your target .NET Framework profile. For more information, see [Troubleshooting .NET Framework Targeting Errors](/visualstudio/msbuild/troubleshooting-dotnet-framework-targeting-errors).

displayName: get started
href: getting-started/index.md
- name: Introduction to the C# language and the .NET framework
- name: Introduction to the C# language and .NET
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another link to the old C# intro that I propose we retire.

bradriske and others added 2 commits August 13, 2020 12:11
The new term is "target framework moniker"

Co-authored-by: Bill Wagner <[email protected]>
@bradriske
Copy link
Contributor Author

Is there anything pending on this for the pull or just long term planning?

@tdykstra
Copy link
Contributor

It should be ready to go, after merge conflicts are resolved.

@BillWagner BillWagner modified the milestones: August 2020, September 2020 Sep 1, 2020
@tdykstra tdykstra merged commit 2a43922 into dotnet:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants