Skip to content

WebRequest deprecation #20310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 26, 2021
Merged

WebRequest deprecation #20310

merged 6 commits into from
Apr 26, 2021

Conversation

aik-jahoda
Copy link
Contributor

@aik-jahoda aik-jahoda commented Aug 27, 2020 •
edited by gewarren
Loading

Summary

Deprecation of WebRequest

Preview link

Part of dotnet/runtime#33125

@dotnet-bot dotnet-bot added this to the August 2020 milestone Aug 27, 2020
@aik-jahoda aik-jahoda requested a review from karelz August 27, 2020 12:21
aik-jahoda
aik-jahoda commented Aug 27, 2020
View reviewed changes
docs/core/compatibility/fx-core.md

### .NET Core 2.0

[!INCLUDE [behavior-change-webclient-cancelasync](../../../includes/core-changes/networking/2.0/behavior-change-webclient-cancelasync.md)]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider merge behavior-change-webclient-cancelasync.md chapter with behavior-change-webrequest-deprecate.md

@aik-jahoda
Copy link
Contributor Author

@gewarren @karelz, this is potentially sensitive topic and need explain reasons why we decided to deprecate WebRequest api. Can you please review this draft and add suggestions how to send correct message to customers?

@scalablecory scalablecory mentioned this pull request Aug 27, 2020
Closed
4 tasks
Youssef1313
Youssef1313 reviewed Aug 27, 2020
View reviewed changes
gewarren
gewarren reviewed Sep 1, 2020
View reviewed changes
docs/core/compatibility/3.1-5.0.md Outdated

- [WinHttpHandler removed from .NET runtime](#winhttphandler-removed-from-net-runtime)
- [MulticastOption.Group doesn't accept a null value](#multicastoptiongroup-doesnt-accept-a-null-value)
- [WebRequest, WebClient and ServicePoint are deprecated](#webrequest-webclient-and-servicepoint-are-deprecated)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [WebRequest, WebClient and ServicePoint are deprecated](#webrequest-webclient-and-servicepoint-are-deprecated)
- [WebRequest, WebClient, and ServicePoint are deprecated](#webrequest-webclient-and-servicepoint-are-deprecated)

@BillWagner BillWagner modified the milestones: August 2020, September 2020 Sep 1, 2020
@gewarren
Copy link
Contributor

gewarren commented Sep 2, 2020

Please also add the include link to the networking category file: https://github.com/dotnet/docs/blob/master/docs/core/compatibility/networking.md

@IEvangelist
Copy link
Member

Hi @aik-jahoda - is this still relevant or needed? This is still marked as a draft.

@aik-jahoda aik-jahoda force-pushed the jajahoda/servicepointcert branch from 17cd59b to 17bd6db Compare February 16, 2021 16:54
@aik-jahoda
Copy link
Contributor Author

@IEvangelist yep, it is still valid, I have retargeted it to .net 6.

@karelz - this topic is important for people moving to .net 6, can you please take a look? The classes are deprecated .net 6 so we should push this forward.

@BillWagner BillWagner modified the milestones: February 2021, March 2021 Mar 5, 2021
Base automatically changed from master to main March 5, 2021 23:33
Base automatically changed from main to master March 17, 2021 17:05
Base automatically changed from master to main March 17, 2021 17:06
@BillWagner BillWagner modified the milestones: March 2021, April 2021 Mar 29, 2021
@gewarren gewarren marked this pull request as ready for review April 26, 2021 18:33
Youssef1313
Youssef1313 reviewed Apr 26, 2021
View reviewed changes
docs/core/compatibility/networking/6.0/webrequest-deprecated.md
### Category
Networking
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core libraries feels like a valid category too, but how the docs are organized doesn't allow multiple categories. Are there any criteria to prefer one over the other?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "Core .NET libraries" is for anything that doesn't fit in one of the other categories. So Networking is fine here.

@gewarren gewarren merged commit 04c3392 into dotnet:main Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@gewarren gewarren gewarren approved these changes

@karelz karelz Awaiting requested review from karelz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
April 2021
Development

Successfully merging this pull request may close these issues.
6 participants
@aik-jahoda @gewarren @IEvangelist @Youssef1313 @BillWagner @dotnet-bot