Skip to content

Conversation

@briacht
Copy link
Contributor

@briacht briacht commented Oct 14, 2020

Summary

add image classification to cli scenarios

Copy link
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@briacht thanks for updating this.

I added a comment. Let me know what you think.

- recommendation
- Future: other machine learning tasks such as image-classification, ranking, anomaly-detection, clustering
- image classification
- Future: other machine learning tasks such as ranking, anomaly detection, clustering
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we even need this future bullet point. It's not in the product now, so would remove it and just list what the product supports. Sounds more like a promise and might create confusion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, docs shouldn't mention future plans according to the contributor's guide. @briacht Could you update and then we'll merge?

- recommendation
- Future: other machine learning tasks such as image-classification, ranking, anomaly-detection, clustering
- image classification
- Future: other machine learning tasks such as ranking, anomaly detection, clustering
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, docs shouldn't mention future plans according to the contributor's guide. @briacht Could you update and then we'll merge?

@adegeo
Copy link
Contributor

adegeo commented Feb 16, 2021

@briacht Ping

@BillWagner BillWagner modified the milestones: February 2021, March 2021 Mar 5, 2021
@gewarren gewarren changed the base branch from master to main March 8, 2021 18:39
@briacht
Copy link
Contributor Author

briacht commented Mar 11, 2021

I had to create a new PR: #23283

Also I got rid of the "Future" statement.

@luisquintanilla
Copy link
Contributor

Closing PR since there's a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants