Skip to content

Conversation

Niharikadutta
Copy link
Contributor

@Niharikadutta Niharikadutta commented Oct 27, 2020

Updating following in .NET for Apache Spark documentation:

  1. Latest v1.0.0 release of Spark .NET.
  2. Updating to latest .NET core 3.1 version.
  3. Updating latest naming convention of microsoft-spark jar.
  4. Fixing errors here and there.

Fixes Spark .NET issue

Preview URLs:

File Type File Name Published Url
Content docs/spark/how-to-guides/broadcast-guide.md https://review.docs.microsoft.com/en-us/dotnet/spark/how-to-guides/broadcast-guide?branch=pr-en-us-21247
Content docs/spark/how-to-guides/connect-to-mongo-db.md https://review.docs.microsoft.com/en-us/dotnet/spark/how-to-guides/connect-to-mongo-db?branch=pr-en-us-21247
Content docs/spark/how-to-guides/databricks-deploy-methods.md https://review.docs.microsoft.com/en-us/dotnet/spark/how-to-guides/databricks-deploy-methods?branch=pr-en-us-21247
Content docs/spark/how-to-guides/deploy-worker-udf-binaries.md https://review.docs.microsoft.com/en-us/dotnet/spark/how-to-guides/deploy-worker-udf-binaries?branch=pr-en-us-21247
Content docs/spark/how-to-guides/dotnet-spark-jupyter-notebooks.md https://review.docs.microsoft.com/en-us/dotnet/spark/how-to-guides/dotnet-spark-jupyter-notebooks?branch=pr-en-us-21247
Content docs/spark/how-to-guides/hdinsight-deploy-methods.md https://review.docs.microsoft.com/en-us/dotnet/spark/how-to-guides/hdinsight-deploy-methods?branch=pr-en-us-21247
Content docs/spark/how-to-guides/hdinsight-notebook-installation.md https://review.docs.microsoft.com/en-us/dotnet/spark/how-to-guides/hdinsight-notebook-installation?branch=pr-en-us-21247
Content docs/spark/how-to-guides/java-udf-from-dotnet.md https://review.docs.microsoft.com/en-us/dotnet/spark/how-to-guides/java-udf-from-dotnet?branch=pr-en-us-21247
Content docs/spark/how-to-guides/ubuntu-instructions.md https://review.docs.microsoft.com/en-us/dotnet/spark/how-to-guides/ubuntu-instructions?branch=pr-en-us-21247
Content docs/spark/how-to-guides/windows-instructions.md https://review.docs.microsoft.com/en-us/dotnet/spark/how-to-guides/windows-instructions?branch=pr-en-us-21247
Content docs/spark/tutorials/amazon-emr-spark-deployment.md https://review.docs.microsoft.com/en-us/dotnet/spark/tutorials/amazon-emr-spark-deployment?branch=pr-en-us-21247
Content docs/spark/tutorials/batch-processing.md https://review.docs.microsoft.com/en-us/dotnet/spark/tutorials/batch-processing?branch=pr-en-us-21247
Content docs/spark/tutorials/databricks-deployment.md https://review.docs.microsoft.com/en-us/dotnet/spark/tutorials/databricks-deployment?branch=pr-en-us-21247
Content docs/spark/tutorials/get-started.md https://review.docs.microsoft.com/en-us/dotnet/spark/tutorials/get-started?branch=pr-en-us-21247
Content docs/spark/tutorials/hdinsight-deployment.md https://review.docs.microsoft.com/en-us/dotnet/spark/tutorials/hdinsight-deployment?branch=pr-en-us-21247
Content docs/spark/tutorials/ml-sentiment-analysis.md https://review.docs.microsoft.com/en-us/dotnet/spark/tutorials/ml-sentiment-analysis?branch=pr-en-us-21247
Content docs/spark/tutorials/streaming.md https://review.docs.microsoft.com/en-us/dotnet/spark/tutorials/streaming?branch=pr-en-us-21247
Content docs/spark/what-is-apache-spark-dotnet.md https://review.docs.microsoft.com/en-us/dotnet/spark/what-is-apache-spark-dotnet?branch=pr-en-us-21247

@Niharikadutta Niharikadutta changed the title [WIP] Update latest versions in documentation Update latest versions in documentation Oct 28, 2020
@Niharikadutta Niharikadutta marked this pull request as ready for review October 28, 2020 18:33
Copy link
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Added a few comments.

You should now be able to access any Azure Databricks clusters you create and upload files to the DBFS.

## Download worker dependencies
## Download Microsoft Spark Worker dependencies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave as is or find shorter version for subheading. Formatting style guidelines ask for keeping headings to 2 lines (https://docs.microsoft.com/en-us/style-guide/scannable-content/headings#formatting-headings)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reverted this change although I am not sure I understand how the previous change offends the guidelines asking to keep headings to 2 lines, there was just one line to the heading no? Perhaps I am missing something.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text is in one line. However, the headers on the sidebar wrap text. This is what the current one looks like. If you were to expand to Microsoft.Spark.Worker, it would go into 3+ lines.

image

@Niharikadutta
Copy link
Contributor Author

@luisquintanilla Thank you so much for the review, I have addressed all your comments, please let me know if the changes look ok. Thanks!

@luisquintanilla
Copy link
Contributor

Thanks @Niharikadutta for making all the changes. Looks good to me. Approving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Documentation]: Update for 1.0 Release

4 participants