Skip to content

Conversation

eriawan
Copy link
Member

@eriawan eriawan commented Oct 31, 2020

Summary

update .NET Framework to .NET in visual-basic/developing-apps where applicable

Fixes #18698 (partially)

@gewarren
please review.

@eriawan
Copy link
Member Author

eriawan commented Oct 31, 2020

I was going to update other pages within the visual-basic/developing-apps,, but other pages have link to other pages that are having "framework" in the md file name, and some of the pages are having links to other page that only exists in .NET Framework (no .NET Core counterpart doc pages).

For example:

  1. accessing-data.md that has link to .NET Framework only ADO.NET
    image
  2. index.md under visual-basic/developing-apps/programming/drives-directories-files have link to other pages with "framework" names and titles:
    image

On my second point above, could we also rename the file and update the link after we replace .NET Framework with .NET on those pages?

@eriawan
Copy link
Member Author

eriawan commented Nov 2, 2020

team,

please review and if you don't mind also review my previous suggestions above.
Thanks in advance.

cc @BillWagner @KathleenDollard

@BillWagner BillWagner requested a review from gewarren November 2, 2020 14:43
eriawan and others added 6 commits November 3, 2020 00:46
…es/reading-from-and-writing-to-the-registry-using-the-microsoft-win32-namespace.md

Co-authored-by: Genevieve Warren <[email protected]>
…es/reading-from-and-writing-to-the-registry.md

Co-authored-by: Genevieve Warren <[email protected]>
…es/reading-from-and-writing-to-the-registry.md

Co-authored-by: Genevieve Warren <[email protected]>
@eriawan
Copy link
Member Author

eriawan commented Nov 2, 2020

@gewarren
nice catch and feedback!
PR updated.

@gewarren gewarren merged commit 86a0fe3 into dotnet:master Nov 2, 2020
@gewarren
Copy link
Contributor

gewarren commented Nov 2, 2020

@eriawan Thanks!

@eriawan eriawan deleted the change-netframework-to-net-in-visualbasic-developingapps-folder branch November 2, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace .NET Framework with .NET (VB folders)

4 participants