Skip to content

Conversation

cartermp
Copy link
Contributor

Contributes to #21272 by emphasizing package references and, in general, revamping this article to be more of a tutorial than a word dump about F# Interactive.

@cartermp cartermp requested a review from a team as a code owner October 31, 2020 23:34
@dotnet-bot dotnet-bot added this to the October 2020 milestone Oct 31, 2020
@cartermp cartermp requested a review from dsyme October 31, 2020 23:39
Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted a couple typos on a read-through. I like the flow of the new version though :)

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @cartermp

I had a couple small suggestions for you to consider, then you can :shipit:

@cartermp cartermp merged commit 21b554b into dotnet:master Nov 2, 2020
@cartermp cartermp deleted the fs-pkgrefs branch November 2, 2020 18:22
@gewarren
Copy link
Contributor

gewarren commented Nov 3, 2020

@cartermp This PR introduced a couple of build warnings. Can you resolve those?

@cartermp cartermp mentioned this pull request Nov 3, 2020
@cartermp
Copy link
Contributor Author

cartermp commented Nov 3, 2020

Yep, done here: #21326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants