Skip to content

Correct VS instructions #22541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2021
Merged

Correct VS instructions #22541

merged 1 commit into from
Feb 2, 2021

Conversation

tdykstra
Copy link
Contributor

Fixes #21489

@tdykstra tdykstra requested a review from adegeo as a code owner January 28, 2021 00:20
@dotnet-bot dotnet-bot added this to the January 2021 milestone Jan 28, 2021
@tdykstra tdykstra mentioned this pull request Jan 28, 2021
Closed
@tdykstra tdykstra requested review from a team and BillWagner and removed request for a team January 29, 2021 22:54
BillWagner
BillWagner approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @tdykstra

You can :shipit: when ready

@tdykstra tdykstra merged commit b70a15f into master Feb 2, 2021
@tdykstra tdykstra deleted the tdykstra-patch-2 branch February 2, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@adegeo adegeo Awaiting requested review from adegeo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
January 2021
Development

Successfully merging this pull request may close these issues.

"Publish a single file app - Visual Studio" implies that self-contained is required
3 participants
@tdykstra @BillWagner @dotnet-bot