Skip to content

Update cs0568.md #23127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2021
Merged

Update cs0568.md #23127

merged 2 commits into from
Aug 5, 2021

Conversation

Youssef1313
Copy link
Member

Related to dotnet/roslyn#51679

@Youssef1313 Youssef1313 requested a review from BillWagner as a code owner March 5, 2021 06:42
@dotnet-bot dotnet-bot added this to the March 2021 milestone Mar 5, 2021
@BillWagner
Copy link
Member

Thanks @Youssef1313

I've read the changes, and I agree with them. I'll wait to approve and merge until the related roslyn PR is merged.

@gewarren gewarren added the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Mar 5, 2021
Base automatically changed from master to main March 5, 2021 23:33
Base automatically changed from main to master March 17, 2021 17:05
Base automatically changed from master to main March 17, 2021 17:07
@BillWagner BillWagner modified the milestones: March 2021, April 2021 Apr 5, 2021
@BillWagner
Copy link
Member

Moving the milestone, as the related roslyn PR is still open.

@BillWagner BillWagner modified the milestones: April 2021, June 2021 Jun 1, 2021
@BillWagner BillWagner modified the milestones: June 2021, July 2021 Jul 1, 2021
@BillWagner BillWagner enabled auto-merge August 5, 2021 16:22
@BillWagner BillWagner disabled auto-merge August 5, 2021 16:22
@BillWagner BillWagner enabled auto-merge (squash) August 5, 2021 16:22
BillWagner
BillWagner approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, now that the roslyn PR is merged.

@BillWagner BillWagner merged commit 77b93e8 into dotnet:main Aug 5, 2021
@Youssef1313 Youssef1313 deleted the patch-19 branch August 5, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) dotnet-csharp/svc errors-warnings/subsvc
Projects
None yet
Milestone
July 2021
Development

Successfully merging this pull request may close these issues.
4 participants
@Youssef1313 @BillWagner @dotnet-bot @gewarren