-
Notifications
You must be signed in to change notification settings - Fork 6k
Update new top-level template changes #26248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| For most users, you need take no action. However, this change can cause type-name conflicts with the namespaces that are implicitly included. If that happens, modify the list of `global using` directives or fully qualify your type references. You can modify the list of `global using` directives in several ways: | ||
|
|
||
| - Disable the feature completely by setting `<DisableImplicitNamespaceImports>` to `true` in the project file. For more information, see [DisableImplicitNamespaceImports](../../../project-sdk/msbuild-props.md#disableimplicitnamespaceimports). | ||
| - Disable the feature completely by setting `<ImplicitUsings>` to `false` in the project file. For more information, see [ImplicitUsings](../../../project-sdk/msbuild-props.md#implicitusings). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that we should update this specific article. It is specific to .NET 6 Preview 7, as noted in the intro, and so it refers to the older syntax (that was changed in RC 1).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it would make sense to leave this stuck at Preview 7. It's effectively an article about changes introduced in .NET 6, and after GA it will cover what's different from 5.0 to 6.0.
EDIT: I was thinking this comment was about the top-level-templates article, but I think this article too could be rewritten to function as .NET 5 to .NET 6 GA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's more complicated than that. Preview 7 turned on implicit usings for new and existing projects. RC 1 introduced a new breaking change where implicit usings were disabled for existing projects. So that single breaking change article really is specific to Preview 7. The new syntax is already covered in the RC 1 breaking change article at https://docs.microsoft.com/en-us/dotnet/core/compatibility/sdk/6.0/implicit-namespaces-rc1. And since it's only enabled for new projects going forward, that's not considered a breaking change - so both breaking change articles should be deleted once .NET 6 GAs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll revert this file.
Co-authored-by: Genevieve Warren <[email protected]>
…o adegeo-26146-toplevel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM @adegeo
You can
when ready.
Summary
<ImplicitUsings>Fixes #26146
@gewarren @BillWagner @DamianEdwards