Skip to content

Improve dotnet nuget push to Azure DevOps Artifacts documentation #29917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Jun 29, 2022
Merged

Improve dotnet nuget push to Azure DevOps Artifacts documentation #29917

merged 32 commits into from
Jun 29, 2022

Conversation

erdembayar
Copy link
Contributor

@erdembayar erdembayar commented Jun 17, 2022 •
edited
Loading

Fixes: https://github.com/NuGet/docs.microsoft.com-nuget/issues/2787

Description: Improve dotnet nuget push to Azure DevOps Artifacts documentation: https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-nuget-push
Add example for pushing nupkg to Azdo Artifacts.

@dotnet-bot dotnet-bot added this to the June 2022 milestone Jun 17, 2022
@erdembayar erdembayar requested review from a team, nkolev92 and JonDouglas June 18, 2022 00:37
@erdembayar erdembayar marked this pull request as ready for review June 18, 2022 00:38
@erdembayar erdembayar requested a review from tdykstra as a code owner June 18, 2022 00:38
nkolev92
nkolev92 reviewed Jun 20, 2022
View reviewed changes
Copy link
Contributor

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was mostly focusing on the structure first right now.

Hoping @tdykstra can provide some guidance on this.

I haven't reviewed the specific text yet.

jeffkl
jeffkl reviewed Jun 20, 2022
View reviewed changes
Copy link
Contributor

@jeffkl jeffkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitted some wording suggestions. I know this doc already contains references to foo but I don't think we should use that reference in public facing documentation.

erdembayar and others added 7 commits June 21, 2022 12:15
@erdembayar @jeffkl
Accept PR comment1
472f6b7 
Co-authored-by: Jeff Kluge <[email protected]>
@erdembayar @jeffkl
Accept PR comment 2
3f6746d 
Co-authored-by: Jeff Kluge <[email protected]>
@erdembayar @jeffkl
Accept PR comment 2
8ecab46 
Co-authored-by: Jeff Kluge <[email protected]>
@erdembayar @jeffkl
Accept PR comment 4
ba768df 
Co-authored-by: Jeff Kluge <[email protected]>
@erdembayar @jeffkl
Accept PR comment 5
e722eef 
Co-authored-by: Jeff Kluge <[email protected]>
@erdembayar @jeffkl
Accept PR comment 6
247b6bd 
Co-authored-by: Jeff Kluge <[email protected]>
@erdembayar @jeffkl
Accept PR comment 7
ff55fcd 
Co-authored-by: Jeff Kluge <[email protected]>
@IEvangelist IEvangelist enabled auto-merge (squash) June 29, 2022 16:27
@IEvangelist IEvangelist merged commit 1e8f83e into main Jun 29, 2022
@IEvangelist IEvangelist deleted the erdembayar-patch-1 branch June 29, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkan zivkan zivkan left review comments

@jeffkl jeffkl jeffkl left review comments

@nkolev92 nkolev92 nkolev92 approved these changes

@IEvangelist IEvangelist IEvangelist approved these changes

@JonDouglas JonDouglas Awaiting requested review from JonDouglas

@tdykstra tdykstra Awaiting requested review from tdykstra

Assignees
No one assigned
Labels
cli/subsvc dotnet-fundamentals/svc
Projects
None yet
Milestone
June 2022
Development

Successfully merging this pull request may close these issues.

Improve dotnet nuget push to Azure DevOps Artifacts documentation
7 participants
@erdembayar @tdykstra @nkolev92 @zivkan @IEvangelist @jeffkl @dotnet-bot