Skip to content

Fix json sample #34284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2023
Merged

Fix json sample #34284

merged 2 commits into from
Mar 8, 2023

Conversation

WeihanLi
Copy link
Contributor

Summary

Fixes the json sample, it caused an error likes

Member names cannot be the same as their enclosing type

@WeihanLi WeihanLi requested a review from adegeo as a code owner February 27, 2023 15:41
@dotnet-bot dotnet-bot added this to the February 2023 milestone Feb 27, 2023
@ghost ghost added the community-contribution Indicates PR is created by someone from the .NET community. label Feb 27, 2023
gewarren
gewarren reviewed Mar 7, 2023
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WeihanLi, good catch. Can you also fix line 51 to match?

@WeihanLi
Copy link
Contributor Author

WeihanLi commented Mar 8, 2023

@gewarren updated thanks

@gewarren gewarren enabled auto-merge (squash) March 8, 2023 00:45
@gewarren gewarren merged commit 8f2e4b3 into dotnet:main Mar 8, 2023
@WeihanLi WeihanLi deleted the patch-1 branch March 8, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

@adegeo adegeo Awaiting requested review from adegeo

Assignees
No one assigned
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Milestone
February 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@WeihanLi @gewarren @dotnet-bot