Skip to content

Conversation

@stevewhims
Copy link
Contributor

@stevewhims stevewhims commented Jun 2, 2023

Remove the stub topic, and use the TOC to send the reader to the detailed topic.

This will get the reader to the detailed topic more quickly, and will be more economical to maintain going forward.
@stevewhims stevewhims requested a review from a team as a code owner June 2, 2023 22:29
@dotnet-bot dotnet-bot added this to the June 2023 milestone Jun 2, 2023
@ghost ghost added the community-contribution Indicates PR is created by someone from the .NET community. label Jun 2, 2023
@stevewhims
Copy link
Contributor Author

#sign-off

@gewarren gewarren requested a review from adegeo June 6, 2023 18:06
@adegeo
Copy link
Contributor

adegeo commented Jun 6, 2023

👀

Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevewhims why not just put /windows/apps/windows-app-sdk/migrate-to-windows-app-sdk/upgrade-assistant in the TOC instead of this file and then create a redirect?

The toc file is in /docs/navigate/migration-guide

@stevewhims
Copy link
Contributor Author

@stevewhims why not just put /windows/apps/windows-app-sdk/migrate-to-windows-app-sdk/upgrade-assistant in the TOC instead of this file and then create a redirect?

The toc file is in /docs/navigate/migration-guide

I've gone with that direction. Does it look ok?

@adegeo
Copy link
Contributor

adegeo commented Jun 6, 2023

@stevewhims Looks good. I think the redirect should be in .openpublishing.redirection.core.json, and the redirect you filed is missing .md at the end of the file name. Once that's fixed, it's merge time! Thanks!

@stevewhims
Copy link
Contributor Author

@stevewhims Looks good. I think the redirect should be in .openpublishing.redirection.core.json, and the redirect you filed is missing .md at the end of the file name. Once that's fixed, it's merge time! Thanks!

Let's try this. Btw, I can't merge AFAIK, so if I eventually get these changes right, it'd be great if you could merge for me. Thank you!

@BillWagner BillWagner modified the milestones: June 2023, July 2023 Jul 11, 2023
@BillWagner BillWagner modified the milestones: July 2023, August 2023 Aug 4, 2023
@BillWagner BillWagner modified the milestones: August 2023, September 2023 Sep 7, 2023
Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay!

@adegeo adegeo merged commit 072cac0 into dotnet:main Oct 10, 2023
@stevewhims stevewhims deleted the patch-1 branch October 10, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants