Skip to content

Conversation

@agocke
Copy link
Member

@agocke agocke commented Aug 29, 2023

This change mostly moves sections in the AOT docs around to put our recommended features near the top, and the rarer options near the bottom.


Internal previews

Toggle expand/collapse
📄 File 🔗 Preview link
docs/core/deploying/native-aot/diagnostics.md Diagnostics and instrumentation
docs/core/deploying/native-aot/fixing-warnings.md Introduction to AOT warnings
docs/core/deploying/native-aot/index.md [Windows](https://review.learn.microsoft.com/en-us/dotnet/core/deploying/native-aot/index?branch=pr-en-us-36885)
docs/core/deploying/native-aot/interop.md Native code interop with Native AOT
docs/core/deploying/native-aot/optimizing.md Optimize AOT deployments
docs/core/deploying/native-aot/warnings/il3050.md IL3050: Avoid calling members annotated with 'RequiresDynamicCodeAttribute' when publishing as Native AOT
docs/core/deploying/native-aot/warnings/il3052.md docs/core/deploying/native-aot/warnings/il3052
docs/core/deploying/native-aot/warnings/il3053.md IL3053: Assembly produced AOT warnings
docs/core/deploying/native-aot/warnings/il3054.md "IL3054: Generic expansion to a method or type was aborted due to generic recursion"
docs/core/diagnostics/index.md What diagnostic tools are available in .NET Core?
docs/core/tools/dotnet-new-sdk-templates.md docs/core/tools/dotnet-new-sdk-templates
docs/core/whats-new/dotnet-8.md What's new in .NET 8
docs/standard/glossary.md .NET glossary
docs/standard/native-interop/pinvoke-source-generation.md Source generation for platform invokes

This change mostly moves sections in the AOT docs around to
put our recommended features near the top, and the rarer options
near the bottom.
@agocke agocke requested review from LakshanF and sbomer August 29, 2023 20:02
@agocke agocke requested a review from adegeo as a code owner August 29, 2023 20:02
@dotnet-bot dotnet-bot added this to the August 2023 milestone Aug 29, 2023
@LakshanF LakshanF requested a review from elinor-fung August 30, 2023 18:16
Copy link
Contributor

@LakshanF LakshanF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The top feature in the table ("Observability") mismatches the title, "Observability and telemetry", in the description below. Otherwise looks good to me.

@agocke
Copy link
Member Author

agocke commented Sep 6, 2023

@elinor-fung Anything else? I think I addressed all your comments

Copy link
Member

@elinor-fung elinor-fung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think https://github.com/dotnet/AspNetCore.Docs will also need a pass for the native AOT / Native AOT change.

@BillWagner BillWagner modified the milestones: August 2023, September 2023 Sep 7, 2023
@agocke agocke enabled auto-merge (squash) September 7, 2023 17:30
@agocke agocke disabled auto-merge September 11, 2023 20:04
@agocke agocke merged commit 6ff474a into dotnet:main Sep 11, 2023
@agocke agocke deleted the aot-changes branch September 11, 2023 20:07
IEvangelist pushed a commit to IEvangelist/docs that referenced this pull request Oct 2, 2023
This change mostly moves sections in the AOT docs around to
put our recommended features near the top, and the rarer options
near the bottom.

Co-authored-by: Sven Boemer <[email protected]>
Co-authored-by: Elinor Fung <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants