Skip to content

ReplayCheck tests for using String.Split #38653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 12, 2024
Merged

ReplayCheck tests for using String.Split #38653

merged 2 commits into from
Jan 12, 2024

Conversation

BillWagner
Copy link
Member

@BillWagner BillWagner commented Dec 7, 2023 •
edited by github-actions bot
Loading

Add the initial tests for the samples on String.Split

Internal previews

📄 File 🔗 Preview link
docs/csharp/how-to/parse-strings-using-split.md How to separate strings using String.Split in C#

@BillWagner
Add tests for using String.Split
f8edcea 
Add the initial tests for the samples on String.Split
@dotnet-bot dotnet-bot added this to the December 2023 milestone Dec 7, 2023
@BillWagner BillWagner changed the title Add tests for using String.Split Create tests for using String.Split Dec 7, 2023
@BillWagner BillWagner changed the title Create tests for using String.Split ReplayCheck tests for using String.Split Dec 8, 2023
@BillWagner
use multiple "contains"
d16bd28 
To make the tests work, you need to use multiple "Contains", rather than "value"
@BillWagner BillWagner modified the milestones: December 2023, January 2024 Jan 8, 2024
@BillWagner BillWagner changed the base branch from main to replay-check-tests January 11, 2024 19:32
@BillWagner
Copy link
Member Author

Marked ready for review.

Base branch changed to "replay-check-tests"

@BillWagner BillWagner marked this pull request as ready for review January 11, 2024 19:32
@BillWagner BillWagner requested a review from a team as a code owner January 11, 2024 19:32
@BillWagner BillWagner requested a review from tdykstra January 11, 2024 19:32
tdykstra
tdykstra approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BillWagner BillWagner merged commit afad514 into dotnet:replay-check-tests Jan 12, 2024
@BillWagner BillWagner deleted the split-strings-tests branch January 12, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdykstra tdykstra tdykstra approved these changes

Assignees

No one assigned

Labels

dotnet-csharp/svc fundamentals/subsvc

Projects

None yet

Milestone

January 2024

Development

Successfully merging this pull request may close these issues.

3 participants

@BillWagner @tdykstra @dotnet-bot