Skip to content

Conversation

BartoszKlonowski
Copy link
Contributor

@BartoszKlonowski BartoszKlonowski commented Dec 10, 2023

@dotnet-bot dotnet-bot added this to the December 2023 milestone Dec 10, 2023
@ghost ghost added the community-contribution Indicates PR is created by someone from the .NET community. label Dec 10, 2023
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @BartoszKlonowski

I had one clarifying comment, and then it's ready to :shipit:

@BartoszKlonowski
Copy link
Contributor Author

Closing and reopening to re-trigger the build.

@BillWagner
Copy link
Member

One note that I missed this morning: You need to add this file to the toc.yml in the compiler-messages folder. (Otherwise, the reader gets lost on this article, because it's not in a TOC.)

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @BartoszKlonowski

Thanks again for all the work you've done. I'll :shipit: now.

@BillWagner BillWagner merged commit adfe867 into dotnet:main Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants