Skip to content

Conversation

BillWagner
Copy link
Member

@BillWagner BillWagner commented May 29, 2024

Fixes #40541

Add an include note for all samples in this section. Point out that all use IEnumerable based collections, so some restrictions will apply when an IQueryable source is used, and expressions are created.

Also, point out that each IQueryProvider has unique restrictions.

Finally, update the left join method syntax sample to use SelectMany which is closer to the lowered code.

Fixes #41095

Move paragraph about statement lambdas to the limitations section.


Internal previews

Toggle expand/collapse
📄 File 🔗 Preview link
docs/csharp/advanced-topics/expression-trees/index.md Expression Trees
docs/csharp/linq/standard-query-operators/converting-data-types.md "Converting Data Types"
docs/csharp/linq/standard-query-operators/filtering-data.md Filtering Data in C# with LINQ
docs/csharp/linq/standard-query-operators/grouping-data.md docs/csharp/linq/standard-query-operators/grouping-data
docs/csharp/linq/standard-query-operators/index.md Standard Query Operators Overview
docs/csharp/linq/standard-query-operators/join-operations.md Join Operations in LINQ
docs/csharp/linq/standard-query-operators/partitioning-data.md "Partitioning data"
docs/csharp/linq/standard-query-operators/projection-operations.md Projection operations (C#)
docs/csharp/linq/standard-query-operators/quantifier-operations.md Quantifier operations in LINQ (C#)
docs/csharp/linq/standard-query-operators/set-operations.md docs/csharp/linq/standard-query-operators/set-operations
docs/csharp/linq/standard-query-operators/sorting-data.md Sorting Data (C#)

Fixes dotnet#40541

Add an include note for all samples in this section. Point out that all use `IEnumerable` based collections, so some restrictions will apply when an `IQueryable` source is used, and expressions are created.

Also, point out that each `IQueryProvider` has unique restrictions.

Finally, update the left join method syntax sample to use `SelectMany` which is closer to the lowered code.
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to use an instead of a as it should read "an IEnumerable".

@BillWagner BillWagner enabled auto-merge (squash) May 30, 2024 12:44
@BillWagner BillWagner merged commit fcb4005 into dotnet:main May 30, 2024
@BillWagner BillWagner deleted the fix-left-join-sample branch May 30, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move statement about a limitation into the Limitations section Invalid LINQ Left Join example
3 participants