-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating tutorials for C# Dev KIt #41440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, I left a few comments. I've only gone through the first tutorial, will start on 2-5 Monday. I'm only reviewing .NET 8 sections -- I left a comment with suggestions on how to deal with 6-7.
Co-authored-by: Tom Dykstra <[email protected]>
Co-authored-by: Tom Dykstra <[email protected]>
Co-authored-by: Tom Dykstra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I noted some minor issues and one that will take some time to fix (terminal vs. debug console).
@webreidi If your time for working on this is limited at the moment, let me know if you'd like me to address the remaining feedback myself in a PR to your PR branch. I expect to have some time I could spend on it next week. |
Co-authored-by: Tom Dykstra <[email protected]>
Co-authored-by: Tom Dykstra <[email protected]>
Co-authored-by: Tom Dykstra <[email protected]>
Co-authored-by: Tom Dykstra <[email protected]>
Co-authored-by: Tom Dykstra <[email protected]>
Co-authored-by: Tom Dykstra <[email protected]>
Co-authored-by: Tom Dykstra <[email protected]>
Yeah, I get very limited time to work on things as I'm pulled in a million directions. If you have time to finish this one up, I would greatly appreciate it. |
@tdykstra Is this ready to go? |
No it's not, as I've been focusing on other things. If I don't get to it this week I'll finish it this weekend. |
@webreidi I added a commit that addresses the remaining issues. Please review and if it looks good we can merge this. |
Summary
I've updated a set of the dotnet tutorials for VS Code to incorporate the usage of C# Dev Kit. I'll be doing a set of these periodically as I get time.
Fixes #42612
Internal previews