Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating tutorials for C# Dev KIt #41440

Merged
merged 21 commits into from
Sep 16, 2024
Merged

Updating tutorials for C# Dev KIt #41440

merged 21 commits into from
Sep 16, 2024

Conversation

Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, I left a few comments. I've only gone through the first tutorial, will start on 2-5 Monday. I'm only reviewing .NET 8 sections -- I left a comment with suggestions on how to deal with 6-7.

docs/core/tutorials/with-visual-studio-code.md Outdated Show resolved Hide resolved
docs/core/tutorials/with-visual-studio-code.md Outdated Show resolved Hide resolved
docs/core/tutorials/with-visual-studio-code.md Outdated Show resolved Hide resolved
docs/core/tutorials/with-visual-studio-code.md Outdated Show resolved Hide resolved
docs/core/tutorials/with-visual-studio-code.md Outdated Show resolved Hide resolved
docs/core/tutorials/with-visual-studio-code.md Outdated Show resolved Hide resolved
docs/core/tutorials/with-visual-studio-code.md Outdated Show resolved Hide resolved
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I noted some minor issues and one that will take some time to fix (terminal vs. debug console).

@tdykstra
Copy link
Contributor

@webreidi If your time for working on this is limited at the moment, let me know if you'd like me to address the remaining feedback myself in a PR to your PR branch. I expect to have some time I could spend on it next week.

webreidi and others added 7 commits July 9, 2024 12:54
Co-authored-by: Tom Dykstra <[email protected]>
Co-authored-by: Tom Dykstra <[email protected]>
Co-authored-by: Tom Dykstra <[email protected]>
Co-authored-by: Tom Dykstra <[email protected]>
Co-authored-by: Tom Dykstra <[email protected]>
Co-authored-by: Tom Dykstra <[email protected]>
Co-authored-by: Tom Dykstra <[email protected]>
@webreidi
Copy link
Contributor Author

webreidi commented Jul 9, 2024

@webreidi If your time for working on this is limited at the moment, let me know if you'd like me to address the remaining feedback myself in a PR to your PR branch. I expect to have some time I could spend on it next week.

Yeah, I get very limited time to work on things as I'm pulled in a million directions. If you have time to finish this one up, I would greatly appreciate it.

@BillWagner BillWagner modified the milestones: July 2024, August 2024 Aug 13, 2024
@gewarren
Copy link
Contributor

gewarren commented Sep 5, 2024

@tdykstra Is this ready to go?

@tdykstra
Copy link
Contributor

tdykstra commented Sep 5, 2024

@tdykstra Is this ready to go?

No it's not, as I've been focusing on other things. If I don't get to it this week I'll finish it this weekend.

@tdykstra tdykstra modified the milestones: August 2024, October 2024 Sep 10, 2024
@tdykstra tdykstra requested a review from a team as a code owner September 12, 2024 22:35
@dotnet-policy-service dotnet-policy-service bot added the okr-freshness OKR: Freshness of content label Sep 12, 2024
@tdykstra tdykstra modified the milestones: October 2024, September 2024 Sep 12, 2024
@tdykstra
Copy link
Contributor

@webreidi I added a commit that addresses the remaining issues. Please review and if it looks good we can merge this.

@tdykstra tdykstra closed this Sep 13, 2024
@tdykstra tdykstra reopened this Sep 13, 2024
@tdykstra tdykstra self-requested a review September 13, 2024 14:39
@tdykstra tdykstra merged commit 65cb9d8 into main Sep 16, 2024
8 checks passed
@tdykstra tdykstra deleted the webreidi/tutorialChanges1 branch September 16, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating tutorials for C# Dev KIt
5 participants