Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding HttpWebRequest to HttpClient Migration Guide #42242

Merged
merged 27 commits into from
Sep 27, 2024

Conversation

liveans
Copy link
Member

@liveans liveans commented Aug 19, 2024

Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far, do you plan to add more complex examples showcasing how to migrate use of certificates or ConnectCallback?

@liveans
Copy link
Member Author

liveans commented Aug 20, 2024

looks good so far, do you plan to add more complex examples showcasing how to migrate use of certificates or ConnectCallback?

Yes, this is ongoing work and this is on my todo list, and I'll actually add specific links to those sections in Notes section in the table.

@BillWagner BillWagner modified the milestones: August 2024, September 2024 Sep 3, 2024
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the examples for specific scenarios, it's very practical. I also like the quick reference tables with the mapping.
Overall, I like the direction here, keep going!

I left some comments, mostly about sample code. I think we should be very careful with the code as people will copy-paste this as-is.

Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this, it'll be nice to have a common place we can link people to

@liveans liveans changed the title [DRAFT] Adding HttpWebRequest to HttpClient Migration Guide Adding HttpWebRequest to HttpClient Migration Guide Sep 22, 2024
@liveans liveans marked this pull request as ready for review September 22, 2024 07:30
@liveans liveans requested a review from a team as a code owner September 22, 2024 07:30
Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this.

(don't get scared by the number of comments, it's mainly small tweaks in example code)

@liveans
Copy link
Member Author

liveans commented Sep 27, 2024

@dotnet/docs gentle reminder on this PR, can you take a look or I can merge this as-is and can create a follow-up PR for reviews.

@liveans liveans merged commit cdb80ff into dotnet:main Sep 27, 2024
8 checks passed
@liveans liveans deleted the httpwebrequest_migration_guide branch September 27, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document HttpClient migration from HttpWebRequest/ServicePoint(Manager)
6 participants