-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding HttpWebRequest to HttpClient Migration Guide #42242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good so far, do you plan to add more complex examples showcasing how to migrate use of certificates or ConnectCallback?
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
Yes, this is ongoing work and this is on my todo list, and I'll actually add specific links to those sections in Notes section in the table. |
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the examples for specific scenarios, it's very practical. I also like the quick reference tables with the mapping.
Overall, I like the direction here, keep going!
I left some comments, mostly about sample code. I think we should be very careful with the code as people will copy-paste this as-is.
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this, it'll be nice to have a common place we can link people to
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this.
(don't get scared by the number of comments, it's mainly small tweaks in example code)
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
docs/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest.md
Outdated
Show resolved
Hide resolved
docs/fundamentals/networking/snippets/httpclient/Program.TruncatedReadStream.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Miha Zupan <[email protected]>
@dotnet/docs gentle reminder on this PR, can you take a look or I can merge this as-is and can create a follow-up PR for reviews. |
Summary
Fixes dotnet/runtime#92690
/cc @dotnet/ncl
Internal previews