Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into live #42552

Merged
merged 37 commits into from
Sep 10, 2024
Merged

Merge main into live #42552

merged 37 commits into from
Sep 10, 2024

Conversation

dotnet-policy-service[bot]
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot commented Sep 10, 2024

Please don't squash-merge this PR.


Internal previews

Toggle expand/collapse
📄 File 🔗 Preview link
docs/core/project-sdk/msbuild-props.md docs/core/project-sdk/msbuild-props
docs/core/project-sdk/overview.md docs/core/project-sdk/overview
docs/core/testing/unit-testing-mstest-runner-intro.md docs/core/testing/unit-testing-mstest-runner-intro
docs/core/testing/unit-testing-mstest-sdk.md docs/core/testing/unit-testing-mstest-sdk
docs/core/testing/unit-testing-platform-faq.md docs/core/testing/unit-testing-platform-faq
docs/core/testing/unit-testing-platform-integration-dotnet-test.md docs/core/testing/unit-testing-platform-integration-dotnet-test
docs/core/testing/unit-testing-platform-intro.md docs/core/testing/unit-testing-platform-intro
docs/csharp/language-reference/compiler-messages/partial-declarations.md docs/csharp/language-reference/compiler-messages/partial-declarations
docs/csharp/language-reference/keywords/extern.md docs/csharp/language-reference/keywords/extern
docs/csharp/language-reference/operators/patterns.md docs/csharp/language-reference/operators/patterns
docs/csharp/misc/cs0525.md docs/csharp/misc/cs0525
docs/fundamentals/runtime-libraries/system-globalization-datetimeformatinfo.md docs/fundamentals/runtime-libraries/system-globalization-datetimeformatinfo
docs/standard/base-types/custom-date-and-time-format-strings.md docs/standard/base-types/custom-date-and-time-format-strings
docs/visual-basic/programming-guide/language-features/control-flow/how-to-dispose-of-a-system-resource.md docs/visual-basic/programming-guide/language-features/control-flow/how-to-dispose-of-a-system-resource

geniuszxy and others added 30 commits May 9, 2024 13:16
* #42402 Updated cs0525.md 

#42402

Updated cs0525.md for issue #42402

* Update docs/csharp/misc/cs0525.md

---------

Co-authored-by: Bill Wagner <[email protected]>
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 7.0.0 to 7.0.1.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@4320041...8867c4a)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the dotnet group in /samples/snippets/core/testing/unit-testing-using-nunit/csharp with 1 update: [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest).


Updates `Microsoft.NET.Test.Sdk` from 17.11.0 to 17.11.1
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
- [Commits](microsoft/vstest@v17.11.0...v17.11.1)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the dotnet group in /docs/fundamentals/networking/telemetry/snippets/metrics with 1 update: [Microsoft.Extensions.Diagnostics.Testing](https://github.com/dotnet/extensions).


Updates `Microsoft.Extensions.Diagnostics.Testing` from 8.8.0 to 8.9.1
- [Release notes](https://github.com/dotnet/extensions/releases)
- [Commits](https://github.com/dotnet/extensions/commits)

---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Diagnostics.Testing
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the dotnet group in /samples/snippets/core/testing/unit-testing-vb-nunit/vb with 1 update: [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest).


Updates `Microsoft.NET.Test.Sdk` from 17.11.0 to 17.11.1
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
- [Commits](microsoft/vstest@v17.11.0...v17.11.1)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the dotnet group in /docs/core/testing/snippets/order-unit-tests/csharp/MSTest.Project with 1 update: [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest).


Updates `Microsoft.NET.Test.Sdk` from 17.11.0 to 17.11.1
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
- [Commits](microsoft/vstest@v17.11.0...v17.11.1)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the dotnet group in /docs/core/testing/snippets/unit-testing-using-mstest/csharp with 1 update: [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest).


Updates `Microsoft.NET.Test.Sdk` from 17.11.0 to 17.11.1
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
- [Commits](microsoft/vstest@v17.11.0...v17.11.1)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the dotnet group in /docs/core/tutorials/snippets/library-with-visual-studio/vb with 1 update: [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest).


Updates `Microsoft.NET.Test.Sdk` from 17.11.0 to 17.11.1
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
- [Commits](microsoft/vstest@v17.11.0...v17.11.1)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the dotnet group in /docs/core/testing/snippets/order-unit-tests/csharp/NUnit.TestProject with 1 update: [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest).


Updates `Microsoft.NET.Test.Sdk` from 17.11.0 to 17.11.1
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
- [Commits](microsoft/vstest@v17.11.0...v17.11.1)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the dotnet group in /docs/core/diagnostics/snippets/exception-summary with 1 update: [Microsoft.Extensions.Diagnostics.ExceptionSummarization](https://github.com/dotnet/extensions).


Updates `Microsoft.Extensions.Diagnostics.ExceptionSummarization` from 8.8.0 to 8.9.1
- [Release notes](https://github.com/dotnet/extensions/releases)
- [Commits](https://github.com/dotnet/extensions/commits)

---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Diagnostics.ExceptionSummarization
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the dotnet group in /docs/core/diagnostics/snippets/lifetime-health-checks with 1 update: [Microsoft.Extensions.Diagnostics.HealthChecks.Common](https://github.com/dotnet/extensions).


Updates `Microsoft.Extensions.Diagnostics.HealthChecks.Common` from 8.8.0 to 8.9.1
- [Release notes](https://github.com/dotnet/extensions/releases)
- [Commits](https://github.com/dotnet/extensions/commits)

---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Diagnostics.HealthChecks.Common
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the dotnet group in /docs/core/testing/snippets/unit-testing-using-mstest/csharp/PrimeService.Tests with 1 update: [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest).


Updates `Microsoft.NET.Test.Sdk` from 17.11.0 to 17.11.1
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
- [Commits](microsoft/vstest@v17.11.0...v17.11.1)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the dotnet group in /docs/core/tutorials/snippets/library-with-visual-studio-6-0/csharp/StringLibraryTest with 1 update: [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest).


Updates `Microsoft.NET.Test.Sdk` from 17.11.0 to 17.11.1
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
- [Commits](microsoft/vstest@v17.11.0...v17.11.1)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the dotnet group in /docs/core/resilience/snippets/resilience with 1 update: [Microsoft.Extensions.Resilience](https://github.com/dotnet/extensions).


Updates `Microsoft.Extensions.Resilience` from 8.8.0 to 8.9.1
- [Release notes](https://github.com/dotnet/extensions/releases)
- [Commits](https://github.com/dotnet/extensions/commits)

---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Resilience
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the dotnet group in /samples/snippets/core/testing/unit-testing-vb-mstest/vb with 1 update: [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest).


Updates `Microsoft.NET.Test.Sdk` from 17.11.0 to 17.11.1
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
- [Commits](microsoft/vstest@v17.11.0...v17.11.1)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the dotnet group in /samples/snippets/core/testing/unit-testing-using-dotnet-test/csharp with 1 update: [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest).


Updates `Microsoft.NET.Test.Sdk` from 17.11.0 to 17.11.1
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
- [Commits](microsoft/vstest@v17.11.0...v17.11.1)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The MMM and MMMM formats may include genitive names.
Bumps the dotnet group in /docs/core/whats-new/snippets/dotnet-8/csharp/ConsoleApp with 1 update: [Microsoft.Extensions.Diagnostics.Testing](https://github.com/dotnet/extensions).


Updates `Microsoft.Extensions.Diagnostics.Testing` from 8.8.0 to 8.9.1
- [Release notes](https://github.com/dotnet/extensions/releases)
- [Commits](https://github.com/dotnet/extensions/commits)

---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Diagnostics.Testing
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the dotnet group in /docs/azure/sdk/snippets/unit-testing with 2 updates: [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) and [Moq](https://github.com/moq/moq).


Updates `Microsoft.NET.Test.Sdk` from 17.11.0 to 17.11.1
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
- [Commits](microsoft/vstest@v17.11.0...v17.11.1)

Updates `Moq` from 4.20.71 to 4.20.72
- [Release notes](https://github.com/moq/moq/releases)
- [Changelog](https://github.com/devlooped/moq/blob/main/changelog.md)
- [Commits](moq/moq.spikes@v4.20.71...v4.20.72)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
- dependency-name: Moq
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the dotnet group in /docs/core/testing/snippets/order-unit-tests/csharp/XUnit.TestProject with 1 update: [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest).


Updates `Microsoft.NET.Test.Sdk` from 17.11.0 to 17.11.1
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
- [Commits](microsoft/vstest@v17.11.0...v17.11.1)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the dotnet group in /docs/core/tutorials/snippets/library-with-visual-studio/vb/StringLibraryTest with 1 update: [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest).


Updates `Microsoft.NET.Test.Sdk` from 17.11.0 to 17.11.1
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
- [Commits](microsoft/vstest@v17.11.0...v17.11.1)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the dotnet group in /docs/core/diagnostics/snippets/resource-monitoring with 1 update: [Microsoft.Extensions.Diagnostics.ResourceMonitoring](https://github.com/dotnet/extensions).


Updates `Microsoft.Extensions.Diagnostics.ResourceMonitoring` from 8.8.0 to 8.9.1
- [Release notes](https://github.com/dotnet/extensions/releases)
- [Commits](https://github.com/dotnet/extensions/commits)

---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Diagnostics.ResourceMonitoring
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the dotnet group in /docs/csharp/roslyn-sdk/tutorials/snippets/how-to-write-csharp-analyzer-code-fix/MakeConst/MakeConst.Test with 1 update: [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest).


Updates `Microsoft.NET.Test.Sdk` from 17.11.0 to 17.11.1
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
- [Commits](microsoft/vstest@v17.11.0...v17.11.1)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the dotnet group in /samples/snippets/core/testing/unit-testing-best-practices/csharp with 1 update: [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest).


Updates `Microsoft.NET.Test.Sdk` from 17.11.0 to 17.11.1
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
- [Commits](microsoft/vstest@v17.11.0...v17.11.1)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the dotnet group in /docs/core/resilience/snippets/http-resilience with 1 update: [Microsoft.Extensions.Http.Resilience](https://github.com/dotnet/extensions).


Updates `Microsoft.Extensions.Http.Resilience` from 8.8.0 to 8.9.1
- [Release notes](https://github.com/dotnet/extensions/releases)
- [Commits](https://github.com/dotnet/extensions/commits)

---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Http.Resilience
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
dependabot bot and others added 7 commits September 9, 2024 16:06
#42527)

Bumps the dotnet group in /docs/core/diagnostics/snippets/health-checks with 1 update: [Microsoft.Extensions.Diagnostics.HealthChecks.ResourceUtilization](https://github.com/dotnet/extensions).


Updates `Microsoft.Extensions.Diagnostics.HealthChecks.ResourceUtilization` from 8.8.0 to 8.9.1
- [Release notes](https://github.com/dotnet/extensions/releases)
- [Commits](https://github.com/dotnet/extensions/commits)

---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Diagnostics.HealthChecks.ResourceUtilization
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the dotnet group in /docs/core/tutorials/snippets/library-with-visual-studio/csharp/StringLibraryTestNet8 with 1 update: [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest).


Updates `Microsoft.NET.Test.Sdk` from 17.11.0 to 17.11.1
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
- [Commits](microsoft/vstest@v17.11.0...v17.11.1)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The file access sample shows the `Using` statement as well,  but doesn't require a connection string.
…42514)

* Make it more clear that a positional pattern relies on `Deconstruct`

 Fixes #42307

* Update docs/csharp/language-reference/operators/patterns.md

Co-authored-by: Genevieve Warren <[email protected]>

---------

Co-authored-by: Genevieve Warren <[email protected]>
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@dotnet-bot dotnet-bot added this to the September 2024 milestone Sep 10, 2024
@dotnet-policy-service dotnet-policy-service bot merged commit a3682c9 into live Sep 10, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants