Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrase the multi-line comments rule to be more precise regarding localization (translations) #42672

Merged

Conversation

BartoszKlonowski
Copy link
Contributor

@BartoszKlonowski BartoszKlonowski commented Sep 20, 2024

This pull request fixes #42053
It rephrases the explanation of the multi-line comments avoidance rule so that it's clear regarding the localization of the page and article versus the embedded comments.


Internal previews

📄 File 🔗 Preview link
docs/csharp/fundamentals/coding-style/coding-conventions.md docs/csharp/fundamentals/coding-style/coding-conventions

@dotnet-bot dotnet-bot added this to the September 2024 milestone Sep 20, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Sep 20, 2024
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @BartoszKlonowski

This looks great, and I'll :shipit: now.

@BillWagner BillWagner enabled auto-merge (squash) September 23, 2024 13:18
@BillWagner BillWagner merged commit 6f12596 into dotnet:main Sep 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-csharp/svc fundamentals/subsvc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ambiguous statment - Comment style - Why avoid multi-line comments (/* */) for longer explanations
3 participants