[BULK] - DocuTune remediation - Sensitive terms with GUIDs #43126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#docutune-review |
dotnet-policy-service
bot
added
the
community-contribution
gewarren
reviewed
Oct 20, 2024
| @@ -251,7 +251,7 @@ The ability to create a project for an earlier TFM depends on having that versio | |||
|
|
|||
| - **`--tenant-id <ID>`** | |||
|
|
|||
| The TenantId ID of the directory to connect to. Use with `SingleOrg` authentication. The default value is `22222222-2222-2222-2222-222222222222`. | |||
| The TenantId ID of the directory to connect to. Use with `SingleOrg` authentication. The default value is `aaaabbbb-0000-cccc-1111-dddd2222eeee`. | |||
There was a problem hiding this comment.
This looks like it changes the meaning and is incorrect.
cilwerner
suggested changes
Oct 21, 2024
| @@ -251,7 +251,7 @@ The ability to create a project for an earlier TFM depends on having that versio | |||
|
|
|||
| - **`--tenant-id <ID>`** | |||
|
|
|||
| The TenantId ID of the directory to connect to. Use with `SingleOrg` authentication. The default value is `22222222-2222-2222-2222-222222222222`. | |||
| The TenantId ID of the directory to connect to. Use with `SingleOrg` authentication. The default value is `aaaabbbb-0000-cccc-1111-dddd2222eeee`. | |||
There was a problem hiding this comment.
Suggested change
| The TenantId ID of the directory to connect to. Use with `SingleOrg` authentication. The default value is `aaaabbbb-0000-cccc-1111-dddd2222eeee`. | |
| The TenantId ID of the directory to connect to. Use with `SingleOrg` authentication. The default value is `22222222-2222-2222-2222-222222222222`. |
| @@ -418,7 +418,7 @@ The ability to create a project for an earlier TFM depends on having that versio | |||
|
|
|||
| - **`--tenant-id <ID>`** | |||
|
|
|||
| The TenantId ID of the directory to connect to. Use with `SingleOrg` authentication. The default value is `22222222-2222-2222-2222-222222222222`. | |||
| The TenantId ID of the directory to connect to. Use with `SingleOrg` authentication. The default value is `aaaabbbb-0000-cccc-1111-dddd2222eeee`. | |||
There was a problem hiding this comment.
Suggested change
| The TenantId ID of the directory to connect to. Use with `SingleOrg` authentication. The default value is `aaaabbbb-0000-cccc-1111-dddd2222eeee`. | |
| The TenantId ID of the directory to connect to. Use with `SingleOrg` authentication. The default value is `22222222-2222-2222-2222-222222222222`. |
| @@ -555,7 +555,7 @@ The ability to create a project for an earlier TFM depends on having that versio | |||
|
|
|||
| - **`--tenant-id <ID>`** | |||
|
|
|||
| The TenantId ID of the directory to connect to. Use with `SingleOrg` authentication. The default value is `22222222-2222-2222-2222-222222222222`. | |||
| The TenantId ID of the directory to connect to. Use with `SingleOrg` authentication. The default value is `aaaabbbb-0000-cccc-1111-dddd2222eeee`. | |||
There was a problem hiding this comment.
Suggested change
| The TenantId ID of the directory to connect to. Use with `SingleOrg` authentication. The default value is `aaaabbbb-0000-cccc-1111-dddd2222eeee`. | |
| The TenantId ID of the directory to connect to. Use with `SingleOrg` authentication. The default value is `22222222-2222-2222-2222-222222222222`. |
| @@ -764,7 +764,7 @@ Creates a web API project with AOT publish enabled. For more information, see [N | |||
|
|
|||
| - **`--tenant-id <ID>`** | |||
|
|
|||
| The TenantId ID of the directory to connect to. Use with `SingleOrg` authentication. The default value is `22222222-2222-2222-2222-222222222222`. | |||
| The TenantId ID of the directory to connect to. Use with `SingleOrg` authentication. The default value is `aaaabbbb-0000-cccc-1111-dddd2222eeee`. | |||
There was a problem hiding this comment.
Suggested change
| The TenantId ID of the directory to connect to. Use with `SingleOrg` authentication. The default value is `aaaabbbb-0000-cccc-1111-dddd2222eeee`. | |
| The TenantId ID of the directory to connect to. Use with `SingleOrg` authentication. The default value is `22222222-2222-2222-2222-222222222222`. |
|
@gewarren - Looks like Chris reverted the changes. Should we just go ahead and close this PR? I've added the GUID 22222222-2222-2222-2222-222222222222 to the allow list since it wasn't nominated and discovered until now. |
Those changes still need to be committed and merged. |
|
PR needs to be closed. I've added the GUID to the allow list. #please-close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying sensitive terms with GUID changes as part of Content SFI and outlined in Overview - Writing content securely - Platform Manual. Changes are part of the Microsoft-wide SFI effort. Point of contact: @celesteg
DocuTune v1.5.2.0
CorrelationId: ac15aa43-4e2b-437f-ab1c-fdd7e79cd4db
#docutune
Internal previews