Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Uri redaction breaking change docs #43795

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

antonfirsov
Copy link
Member

@antonfirsov antonfirsov commented Nov 28, 2024

Summary

The docs did not document that the fragment part is also being redacted away, which turned out to be problematic, see discussion in dotnet/runtime#109847.


Internal previews

📄 File 🔗 Preview link
docs/core/compatibility/networking/9.0/query-redaction-events.md URI query and fragment redaction in HttpClient EventSource events
docs/core/compatibility/networking/9.0/query-redaction-logs.md "URI query redaction in IHttpClientFactory logs"

@antonfirsov antonfirsov requested a review from a team as a code owner November 28, 2024 17:29
@dotnetrepoman dotnetrepoman bot added this to the November 2024 milestone Nov 28, 2024
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @antonfirsov

I'll :shipit: now.

@BillWagner BillWagner merged commit 832b05a into dotnet:main Dec 2, 2024
10 checks passed
@gewarren gewarren mentioned this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants