-
Couldn't load subscription status.
- Fork 6.1k
Freshen string comparison code #44736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a9ec691 to
c323684
Compare
e910fa2 to
734e76f
Compare
Add an example that checks equality of instance delegates to point out that the receivers must be the same for those methods.
To fix dotnet#42548, create links between the equality operator and the pattern matching `is` expression, in the case where the right operand is a constant. In addition, add notes in the "How to compare strings" article to bring these together.
734e76f to
ca92690
Compare
Fixes dotnet#20123 Add additional overloads as necessary, and explain the settings that can be applied among the different overloads.
aaecc6c to
e32ecc7
Compare
CamSoper
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Approving with a couple comments.
Co-authored-by: Cam Soper <[email protected]>
…r/docs into string-split-overloads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dotnet-csharp/svc
fundamentals/subsvc
lang-reference/subsvc
okr-freshness
OKR: Freshness of content
okr-quality
Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String.Splitoverloads.==is similar to the pattern matchingis, and!=is similar to the pattern matchingis not.Commit by commit history:
==withisfor equality comparisons with constants.Internal previews
isoperator - Match an expression against a type or constant pattern"isandswitchexpressions, and operatorsand,or, andnotin patterns