-
Notifications
You must be signed in to change notification settings - Fork 6k
What's New - .NET 10 Preview 1 #44878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed after commit 4. What's here looks good so far.
Co-authored-by: Genevieve Warren <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>
Thank you @gewarren! Co-authored-by: Genevieve Warren <[email protected]>
Yes, I don't think we should keep them inline. You can at least verify that they build locally by placing them in separate code files, and then we can use admin perms to override the Snippets 5000 requirement for merging. cc @cmastr P.S. The reason I'm being a stickler is because I was burnt multiple times in the past by not doing this. |
Should you also add ai-assisted metadata to these docs? |
You're no fun, @gewarren. 😝 Okay, I figured out how to build the snippets with the daily build docker container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but let's wait for review from the product team too before merging.
Co-authored-by: Genevieve Warren <[email protected]>
…docs into net10-whats-new
Co-authored-by: Rich Lander <[email protected]>
…docs into net10-whats-new
Fixes #44694
Internal previews