Skip to content

Conversation

@wadepickett
Copy link
Contributor

@wadepickett wadepickett commented Apr 11, 2025

Summary

  • The ASP.NET Build-In Metrics topic has been removed in and, the TOC updated to point to its new location in the aspnetcore.docs repository. (The file was moved to there in a previous PR).
  • Redirection was added to point to the new location of the ASP.NET Core Metrics topic.

Fixes #45580
Fixes dotnet/AspNetCore.Docs#35109

Internal preview test: ASP.NET Core metrics link in TOC
Select in the TOC: Built-in metrics > ASP.NET Core metrics


Internal previews

📄 File 🔗 Preview link
docs/breadcrumb/toc.yml docs/breadcrumb/toc
docs/core/diagnostics/built-in-metrics.md docs/core/diagnostics/built-in-metrics
docs/navigate/tools-diagnostics/toc.yml docs/navigate/tools-diagnostics/toc

@wadepickett
Copy link
Contributor Author

Closing and reopening to attempt re-build since the OPS status checker seems to be having an existential crisis, absorbed in an endless loop of self-reflection...

@wadepickett wadepickett reopened this Apr 12, 2025
@wadepickett wadepickett marked this pull request as ready for review April 12, 2025 01:01
@wadepickett wadepickett requested review from a team and tommcdon as code owners April 12, 2025 01:01
@wadepickett wadepickett requested a review from gewarren April 12, 2025 05:32
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a suggestion with how a contextual TOC link works (you can also read about them in the contributor guide).

@wadepickett
Copy link
Contributor Author

OH! You wanted a breadcrumb! Sorry, I was not catching on. Thanks!

@wadepickett
Copy link
Contributor Author

Internal preview test: ASP.NET Core metrics link in TOC
Select in the TOC: Built-in metrics > ASP.NET Core metrics

@wadepickett wadepickett requested a review from IEvangelist April 15, 2025 01:35
@wadepickett
Copy link
Contributor Author

@IEvangelist, this seems to work fine, but I'm not confident my entry in the docs/breadcrumb/toc.yml is in the right place. gewarren may not be available and I saw you had some contextual links in here so I'm picking on you. :)

Handy Internal preview test link: ASP.NET Core metrics link in TOC
Select in the TOC: Built-in metrics > ASP.NET Core metrics

@wadepickett wadepickett merged commit 5932575 into main Apr 15, 2025
9 checks passed
@wadepickett wadepickett deleted the wade-pickett/35109AspNetMetricsMove branch April 15, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move ASP.NET Core metrics to ASP.NET Core docs repo Move built-in ASP.NET Core metrics from dotnet repo to ASP.NET Core docs repo

3 participants