Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Member signatures in C# don't follow the official formatting rules #6790

Open
MichalStrehovsky opened this issue Jun 3, 2021 · 3 comments · Fixed by #6883
Open

Member signatures in C# don't follow the official formatting rules #6790

MichalStrehovsky opened this issue Jun 3, 2021 · 3 comments · Fixed by #6883
Labels
area-Infrastructure Pri3 Indicates issues/PRs that are low priority

Comments

@MichalStrehovsky
Copy link
Member

E.g. the GC.AddMemoryPressure has the following signature format:

<MemberSignature Language="C#" Value="public static void AddMemoryPressure (long bytesAllocated);" />

Notice the space before the parentheses. This is not how C# signatures are formatted in the rest of the repo or samples. Instead of

public static void AddMemoryPressure (long bytesAllocated);

This should be:

public static void AddMemoryPressure(long bytesAllocated);
@dotnet-bot dotnet-bot added the untriaged New issue has not been triaged by the area owner label Jun 3, 2021
@PRMerger16 PRMerger16 added the Pri3 Indicates issues/PRs that are low priority label Jun 3, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@gewarren
Copy link
Contributor

gewarren commented Jun 9, 2021

@mimisasouvanh Do you have an existing work item for this or should I create a new one?

@gewarren
Copy link
Contributor

@mairaw mairaw removed the untriaged New issue has not been triaged by the area owner label Jun 12, 2021
adegeo added a commit that referenced this issue Jul 13, 2021
* Update GC.xml

Updated according to issue #6790 to comply with official formatting standards

* Update Enumerable.xml

Specify that Take and Skip are complements when the sequences are unrepeatable

* Updated wording according to feedback

Co-authored-by: Steve Berdy <[email protected]>
Co-authored-by: Steve Berdy <[email protected]>
Co-authored-by: Andy De George <[email protected]>
@gewarren gewarren reopened this Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure Pri3 Indicates issues/PRs that are low priority
Projects
None yet
5 participants