Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debian 12 Dockerfile #1276

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add Debian 12 Dockerfile #1276

wants to merge 3 commits into from

Conversation

mthalman
Copy link
Member

@mthalman mthalman commented Dec 3, 2024

This is intended to be the replacement for the Debian 11 Dockerfile that will be removed by #1260.

@richlander
Copy link
Member

Who is using this style of image at this point. My intuition is that we should have Azure Linux build images and helix test images for everything else. Perhaps I'm missing a scenario.

@sbomer

@MichaelSimons
Copy link
Member

Who is using this style of image at this point. My intuition is that we should have Azure Linux build images and helix test images for everything else. Perhaps I'm missing a scenario.

One important instance using this style of image is source-build (although it doesn't use the Debian image specifically). Azure Linux would not be appropriate for Source Build as it is trying to build as close as possible to how maintainers would.

The PowerBI Docker usage report is useful in answering your question. Regarding the Debian image specifically, I only see one usage - dotnet-diagnostics. They are using it for a test leg - https://github.com/dotnet/diagnostics/blob/d12018ba56f7db766272699877908668cba517ef/eng/pipelines/pipeline-resources.yml#L70. Likely the builder image is overkill for their usage.

@richlander
Copy link
Member

Last time I looked at the diagnostics repo, it seems like they were using old patterns. I think we need to stop providing them with images perpetuating old patterns. We should be certain we need non-helix images going forward.

@MichaelSimons
Copy link
Member

Last time I looked at the diagnostics repo, it seems like they were using old patterns. I think we need to stop providing them with images perpetuating old patterns. We should be certain we need non-helix images going forward.

@hoyosjs and @mikem8361, can you comment on what the Debian requirements are for the diagnostic test leg that is using the buildtools Debian image? It is currently utilizing a "builder" image which carries build tools like cmake, etc.

@mikem8361
Copy link
Member

Last time I looked at the diagnostics repo, it seems like they were using old patterns. I think we need to stop providing them with images perpetuating old patterns. We should be certain we need non-helix images going forward.

@hoyosjs and @mikem8361, can you comment on what the Debian requirements are for the diagnostic test leg that is using the buildtools Debian image? It is currently utilizing a "builder" image which carries build tools like cmake, etc.

The diagnostics repo only uses the Debian image for testing so it only needs lldb installed. We don't build anything on it.

@richlander
Copy link
Member

Do you need an lldb of a particular version or the one in the distro will typically work?

@mikem8361
Copy link
Member

mikem8361 commented Dec 5, 2024

The version that comes with the distro should be good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants