Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alpine 3.21 helix images #1282

Merged
merged 2 commits into from
Dec 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions src/alpine/3.21/helix/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
FROM library/alpine:3.21 AS venv

RUN apk add --upgrade --no-cache \
cargo \
python3-dev \
build-base \
libffi-dev \
openssl-dev \
gcc \
linux-headers

RUN python3 -m venv /venv && \
source /venv/bin/activate && \
pip download --no-deps helix-scripts --index-url https://dnceng.pkgs.visualstudio.com/public/_packaging/helix-client-prod/pypi/simple && \
pip install ./helix_scripts-*-py3-none-any.whl

FROM library/alpine:3.21

# Install .NET and test dependencies
RUN apk add --upgrade --no-cache \
bash \
coreutils \
curl \
icu-data-full \
icu-libs \
iputils \
krb5-libs \
lldb \
llvm \
lttng-ust \
musl-locales \
numactl \
openssl \
python3 \
python3-dev \
py3-pip \
sudo \
tzdata

# Install libmsquic from testing repository
RUN apk add --repository=http://dl-cdn.alpinelinux.org/alpine/edge/community/ libmsquic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to pull libmsquic from testing repository anymore on alpine starting with version 3.21, we should able to pull it directly as

apk add libmsquic

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had noticed that and was wondering if this would be the guidance. Cool!

I'll make a PR for that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


# Needed for runtime tests to pass
ENV LANG=en-US.UTF-8
RUN echo export LANG=${LANG} >> /etc/profile.d/locale.sh

# create helixbot user and give rights to sudo without password
# Alpine does not support long options
RUN /usr/sbin/adduser -D -g '' -G adm -s /bin/bash -u 1000 helixbot && \
chmod 755 /root && \
echo "helixbot ALL=(ALL) NOPASSWD: ALL" > /etc/sudoers.d/helixbot

USER helixbot

# Install Helix Dependencies

ENV VIRTUAL_ENV=/home/helixbot/.vsts-env
RUN python3 -m venv $VIRTUAL_ENV
ENV PATH="$VIRTUAL_ENV/bin:$PATH"
COPY --from=venv /venv $VIRTUAL_ENV
41 changes: 41 additions & 0 deletions src/alpine/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,47 @@
}
}
]
},
{
"platforms": [
{
"architecture": "amd64",
"dockerfile": "src/alpine/3.21/helix",
"os": "linux",
"osVersion": "alpine3.21",
"tags": {
"alpine-3.21-helix-amd64": {}
}
}
]
},
{
"platforms": [
{
"architecture": "arm",
"dockerfile": "src/alpine/3.21/helix",
"os": "linux",
"osVersion": "alpine3.21",
"tags": {
"alpine-3.21-helix-arm32v7": {}
},
"variant": "v7"
}
]
},
{
"platforms": [
{
"architecture": "arm64",
"dockerfile": "src/alpine/3.21/helix",
"os": "linux",
"osVersion": "alpine3.21",
"tags": {
"alpine-3.21-helix-arm64v8": {}
},
"variant": "v8"
}
]
}
]
}
Expand Down
Loading