Revert "Update EMSDK in net8.0 image" #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fbce38b.
akoeplinger
approved these changes
Dec 6, 2024
|
None of the vulnerabilities are relevant in our case since we don't run untrusted input and aren't using nodejs in a webserver context. Do you know if we can close them as "won't fix"? |
I am not familiar with the EMSDK support model. I see the version we are on is well over a year now. Will we be staying on this version for the lifetime of 8.0? This feels like a recipe for numerous vulnerabilities over it's lifetime. Requesting s360 exceptions is not feasible for these. They are going to tell us to update our dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1283, see #1283 (comment).
@akoeplinger do you have guidance on addressing #1281? Currently runtime is using a stale image for .NET 8:
https://github.com/dotnet/runtime/blob/c8d152ebbc2c97b6cba580fa8079d4e3b2af1516/eng/pipelines/common/templates/pipeline-with-resources.yml#L101 We need to remove the stale reference, but it's for an image that had version 3.1.34 of the EMSDK.