PR feedback

dotnet · Jul 23, 2024 · d01b914 · d01b914
1 parent 90de7b8
commit d01b914
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/Tools/dotnet-monitor/StartupHook/StartupHookApplicator.cs b/src/Tools/dotnet-monitor/StartupHook/StartupHookApplicator.cs
@@ -48,13 +48,13 @@ public async Task<bool> ApplyAsync(string tfm, string fileName, CancellationToke
                 return true;
             }
 
-#nullable disable
             if (_endpointInfo.RuntimeVersion?.Major < 8)
             {
+#nullable disable
                 _logger.StartupHookInstructions(_endpointInfo.ProcessId, fileInfo.Name, fileInfo.PhysicalPath);
+#nullable restore
                 return false;
             }
-#nullable restore
 
             return await ApplyUsingDiagnosticClientAsync(fileInfo, client, token);
         }

diff --git a/src/Tools/dotnet-monitor/ValidationResultExtensions.cs b/src/Tools/dotnet-monitor/ValidationResultExtensions.cs
@@ -10,6 +10,7 @@ internal static class ValidationResultExtensions
     {
         public static bool IsSuccess([NotNullWhen(false)] this ValidationResult? result)
         {
+            // ValidationResult.Success is null, and a null value indicates there are no validation errors.
             return result == ValidationResult.Success;
         }
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -10,6 +10,7 @@ internal static class ValidationResultExtensions @@
         {
             public static bool IsSuccess([NotNullWhen(false)] this ValidationResult? result)
             {
+                // ValidationResult.Success is null, and a null value indicates there are no validation errors.
                 return result == ValidationResult.Success;
             }
         }
@@ Expand Down @@