Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ErrorMessage_CouldNotMapToAction usage #6665

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix ErrorMessage_CouldNotMapToAction usage #6665

merged 1 commit into from
May 21, 2024

Conversation

schmittjoseph
Copy link
Member

@schmittjoseph schmittjoseph commented May 16, 2024 •
edited
Loading

Summary

While working on another feature I came across a bug where we don't use ErrorMessage_CouldNotMapToAction correctly - we weren't supplying the necessary argument to it.

Release Notes Entry

Fix the error log message shown when an action could not be registered.

@schmittjoseph schmittjoseph requested a review from a team as a code owner May 16, 2024 22:50
@jander-msft
Copy link
Member

Do you think this needs to go into release notes? Also, please backport where applicable (presumably all in-support versions).

@schmittjoseph schmittjoseph added update-release-notes Pull requests that should be mentioned in the release notes servicing-patch Servicing fixes that is targeted for a patch release (0.0.x version) servicing-minor Servicing fixes that is targeted for a minor release (0.x.0 version) servicing-major Servicing fixes that is targeted for a major release (x.0.0 version) labels May 20, 2024
@schmittjoseph schmittjoseph merged commit 92ea1fe into dotnet:main May 21, 2024
27 checks passed
@schmittjoseph schmittjoseph deleted the fix-map-to-action branch May 21, 2024 18:22
@schmittjoseph
Copy link
Member Author

/backport to release/6.x

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/6.x: https://github.com/dotnet/dotnet-monitor/actions/runs/9179528967

github-actions bot pushed a commit that referenced this pull request May 21, 2024
@schmittjoseph
Fix ErrorMessage_CouldNotMapToAction (#6665)
e0cd9b2
@github-actions github-actions bot mentioned this pull request May 21, 2024
Merged
@jander-msft
Copy link
Member

/backport to release/8.0

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/dotnet-monitor/actions/runs/9179611067

github-actions bot pushed a commit that referenced this pull request May 21, 2024
@schmittjoseph
Fix ErrorMessage_CouldNotMapToAction (#6665)
5f2032e
@github-actions github-actions bot mentioned this pull request May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jander-msft jander-msft jander-msft approved these changes

Assignees
No one assigned
Labels
servicing-major Servicing fixes that is targeted for a major release (x.0.0 version) servicing-minor Servicing fixes that is targeted for a minor release (0.x.0 version) servicing-patch Servicing fixes that is targeted for a patch release (0.0.x version) update-release-notes Pull requests that should be mentioned in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schmittjoseph @jander-msft