-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nullable Context] Enable on Microsoft.Diagnostics.Monitoring.Options
#6933
Merged
schmittjoseph
merged 7 commits into
dotnet:main
from
schmittjoseph:nullability/options-project
Jul 2, 2024
Merged
[Nullable Context] Enable on Microsoft.Diagnostics.Monitoring.Options
#6933
schmittjoseph
merged 7 commits into
dotnet:main
from
schmittjoseph:nullability/options-project
Jul 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmittjoseph
changed the title
[Nullable Context] Enable on
[Nullable Context] Enable on Jul 1, 2024
Microsoft.Diagnostics.Monitoring.Options.csproj
Microsoft.Diagnostics.Monitoring.Options
schmittjoseph
commented
Jul 1, 2024
schmittjoseph
changed the title
[Nullable Context] Enable on
[DO NOT REVIEW] [Nullable Context] Enable on Jul 1, 2024
Microsoft.Diagnostics.Monitoring.Options
Microsoft.Diagnostics.Monitoring.Options
schmittjoseph
changed the title
[DO NOT REVIEW] [Nullable Context] Enable on
[Nullable Context] Enable on Jul 1, 2024
Microsoft.Diagnostics.Monitoring.Options
Microsoft.Diagnostics.Monitoring.Options
schmittjoseph
commented
Jul 1, 2024
schmittjoseph
commented
Jul 1, 2024
6 tasks
jander-msft
reviewed
Jul 2, 2024
src/Microsoft.Diagnostics.Monitoring.WebApi/Exceptions/ExceptionsSettingsFactory.cs
Outdated
Show resolved
Hide resolved
jander-msft
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable nullable aware context for
Microsoft.Diagnostics.Monitoring.Options
. Just like #6924 this PR only contains no/low risk changes.Release Notes Entry