Hide frames with StackTraceHiddenAttribute from /exceptions and /stacks
#7532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmittjoseph
added
the
update-release-notes
jander-msft
previously approved these changes
Oct 21, 2024
src/Tests/Microsoft.Diagnostics.Monitoring.Tool.FunctionalTests/StacksTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.Diagnostics.Monitoring.Tool.FunctionalTests/ExceptionsTests.cs
Outdated
Show resolved
Hide resolved
jander-msft
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When frames (via their function or declaring type) contain
StackTraceHiddenAttributethey are now hidden from text stack traces. When retrieving json stack traces, they are still included but are identified by a newhiddenfield.The bulk of this PR is updating our
/exceptionsand/stacksfunctional tests + test infrastructure. Also fix a bug with how our profiler identified hidden functions.Release Notes Entry
Hide frames with
StackTraceHiddenAttributefrom/exceptionsand/stacks. When retrieving json data these frames are still included but are identified by a newhiddenfield.