Skip to content

Fix 0-byte reads/writes on blobs #36950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −4
Open

Fix 0-byte reads/writes on blobs #36950

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/Microsoft.Data.Sqlite.Core/SqliteBlob.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,12 @@ public virtual int Read(Span<byte> buffer)
count = (int)(Length - position);
}

var rc = sqlite3_blob_read(_blob, buffer.Slice(0, count), (int)position);
SqliteException.ThrowExceptionForRC(rc, _connection.Handle);
// Newer sqlite3_blob_read returns error for 0-byte reads.
if (count > 0)
{
var rc = sqlite3_blob_read(_blob, buffer.Slice(0, count), (int)position);
SqliteException.ThrowExceptionForRC(rc, _connection.Handle);
}
_position += count;
return count;
}
Expand Down Expand Up @@ -280,8 +284,12 @@ public virtual void Write(ReadOnlySpan<byte> buffer)
throw new NotSupportedException(Resources.ResizeNotSupported);
}

var rc = sqlite3_blob_write(_blob, buffer.Slice(0, count), (int)position);
SqliteException.ThrowExceptionForRC(rc, _connection.Handle);
// Newer sqlite3_blob_write returns error for 0-byte writes.
if (count > 0)
{
var rc = sqlite3_blob_write(_blob, buffer.Slice(0, count), (int)position);
SqliteException.ThrowExceptionForRC(rc, _connection.Handle);
}
_position += count;
}

Expand Down
Loading