Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache current process object to avoid performance hit #5597

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ namespace Microsoft.Extensions.Diagnostics.ResourceMonitoring.Windows.Interop;
[ExcludeFromCodeCoverage]
internal sealed class ProcessInfo : IProcessInfo
{
private static readonly Process _currentProcess = Process.GetCurrentProcess();

public ulong GetMemoryUsage()
{
ulong memoryUsage = 0;
Expand Down Expand Up @@ -41,7 +43,6 @@ public ulong GetMemoryUsage()

public ulong GetCurrentProcessMemoryUsage()
{
using Process process = Process.GetCurrentProcess();
return (ulong)process.WorkingSet64;
return (ulong)_currentProcess.WorkingSet64;
}
}
Loading