[MEDI] Remove collection key type workaround #7010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsitnik
commented
Nov 4, 2025
adamsitnik
commented
Nov 4, 2025
src/Libraries/Microsoft.Extensions.DataIngestion/Writers/VectorStoreWriter.cs
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes a temporary workaround for Qdrant not supporting Guid key types by updating to Semantic Kernel Connectors version 1.67.0-preview, which includes the fix for this limitation.
Key changes:
- Removed the
_keysAreStringsfield and its conditional logic that converted Guid keys to strings for Qdrant - Updated
MicrosoftSemanticKernelConnectorsVersionfrom 1.66.0-preview to 1.67.0-preview
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Libraries/Microsoft.Extensions.DataIngestion/Writers/VectorStoreWriter.cs | Removed workaround for Qdrant's Guid key limitation by eliminating _keysAreStrings field and using Guid keys directly |
| eng/Versions.props | Updated Semantic Kernel Connectors to version 1.67.0-preview which includes support for Guid keys in Qdrant |
MackinnonBuck
added a commit
that referenced
this pull request
Nov 6, 2025
This reverts commit a369be9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to microsoft/semantic-kernel#13315 the workaround is no longer required.
Microsoft Reviewers: Open in CodeFlow