[WIP] Fix F# 5.0 regression in overload resolution #13063
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NinoFloris Do you know if this is fully covered by #13673? |
|
Yes, modulo the improved representation of the conversion info. Also #12946 is similarly fixed but still open. |
|
Since it was fixed, going to close this one, feel free to reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a look at #12860 which was a regression in overload resolution in F# 5.0 when some rules around Nullable interop were added mainly for C# optional parameters.
This proposed fix adjusts overload resolution to match F# 4.7 in this case by preferring methods that do not use the F# 5.0 nullable interop conversions.
This will need more work: