Don't let Glide clear the old image on Android ImageView unless we get an error #23313
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @albyrock87! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
@mattleibow I guess you're the expert on this :) |
albyrock87
commented
Jun 27, 2024
| this.callback = callback; | ||
| } | ||
|
|
||
| @Override | ||
| protected void onResourceCleared(@Nullable Drawable placeholder) { | ||
| this.view.setImageDrawable(placeholder); |
There was a problem hiding this comment.
placeholder is always null here because we never set it on the configuration
src/Core/AndroidNative/maui/src/main/java/com/microsoft/maui/glide/MauiCustomViewTarget.java
Show resolved
Hide resolved
src/Core/AndroidNative/maui/src/main/java/com/microsoft/maui/glide/MauiCustomViewTarget.java
Outdated
Show resolved
Hide resolved
albyrock87
force-pushed
the
fix-android-image-source-switch
branch
from
85bc395
to
185bfe5
Compare
jonathanpeppers
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This post explains very well how Glide works: they replace the image with a placeholder (
nullif not specified in the configuration) right before loading the new one.This causes a slight flickering on the
ImageViewwhile changing the image source.To reproduce this, and verify the fix, I've used the code in issue #6625, which apparently is not entirely fixed on Android.
We have to clear the image only if there was an error loading the new one.
To test the error use case I've added a fake url in the code sample above (i.e.
"https://what.is.this.url.com/nonsenseimage1234567.jpg").I could have cleared the image without creating the
clearedfield, but I wanted to keep part of the existing behavior somehow.Before
before.mov
After
after.mov