Fix iOS log exports #23334
Open
Fix iOS log exports #23334
+56
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
added
the
area-infrastructure
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
PureWeen
force-pushed
the
fix_device_logging
branch
from
5b9be05
to
19c910a
Compare
PureWeen
changed the title
PureWeen
force-pushed
the
fix_device_logging
branch
from
19c910a
to
0354908
Compare
PureWeen
changed the title
PureWeen
requested review from
rmarinho,
jsuarezruiz and
mattleibow
and removed request for
rmarinho and
jsuarezruiz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
At one point we added code to collect all the iOS console logs when running tests. AFAICT none of those added steps successfully gather the logs during test runs. Because the iOS devices are created and then destroyed within the scope of the test run, the device logs no longer exist after the run has finished. This PR should now grab only the logs we care about.