Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SECURITY] Microsoft.Sbom.Targets nuget for package SBOM #26093

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

[SECURITY] Microsoft.Sbom.Targets nuget for package SBOM #26093

wants to merge 12 commits into from

Conversation

moljac
Copy link
Contributor

@moljac moljac commented Nov 25, 2024 •
edited
Loading

Description of Change

Added Microsoft.Sbom.Targets nuget which is used to generate and pack Software Bill of Material (SBOM) of the assets packed in. nuget.

Microsoft.Sbom.Targets was already added to Android Libraries where more details can be found:

dotnet/android-libraries#1052

@moljac moljac requested a review from a team as a code owner November 25, 2024 10:29
@moljac moljac self-assigned this Nov 25, 2024
@moljac moljac marked this pull request as draft November 25, 2024 10:29
mattleibow
mattleibow reviewed Nov 25, 2024
View reviewed changes
src/Controls/Foldable/src/Controls.Foldable.csproj
Comment on lines +27 to +30
<PackageReference Include="Microsoft.Sbom.Targets" Version="$(MicrosoftSbomTargetsPackageVersion)">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this can be moved to the Directory.Build.targets (or some other better file @rmarinho?) and then just include if the IsPackable property is true?

@rmarinho probably can quickly say what the best option here is now with all the arcade fanciness.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. This is something I wasn't sure where to place. Sorry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmarinho probably can quickly say what the best option here is now with all the arcade fanciness.

Sure waiting for input.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yap I agree we should maybe add to the NugetVersion targets ?

https://github.com/dotnet/maui/blob/main/eng/NuGetVersions.targets#L312

@moljac
Copy link
Contributor Author

moljac commented Nov 25, 2024

CI errors dotnet-build task

2024-11-25T15:21:05.5806050Z /Users/builder/azdo/_work/3/s/.dotnet/packs/Microsoft.iOS.Sdk.net9.0_18.0/18.0.9617/tools/msbuild/iOS/Xamarin.Shared.targets(1836,3): error : Could not find any available provisioning profiles for Microsoft.Maui.Essentials.DeviceTests on iOS. [/Users/builder/azdo/_work/3/s/src/Essentials/test/DeviceTests/Essentials.DeviceTests.csproj::TargetFramework=net9.0-ios]
2024-11-25T15:21:05.5807080Z /Users/builder/azdo/_work/3/s/.dotnet/packs/Microsoft.iOS.Sdk.net9.0_18.0/18.0.9617/tools/msbuild/iOS/Xamarin.Shared.targets(1836,3): error :          [/Users/builder/azdo/_work/3/s/src/Essentials/test/DeviceTests/Essentials.DeviceTests.csproj::TargetFramework=net9.0-ios]
2024-11-25T15:21:05.5808100Z /Users/builder/azdo/_work/3/s/.dotnet/packs/Microsoft.iOS.Sdk.net9.0_18.0/18.0.9617/tools/msbuild/iOS/Xamarin.Shared.targets(1836,3): error : Could not find any available provisioning profiles for Microsoft.Maui.Essentials.Sample on iOS. [/Users/builder/azdo/_work/3/s/src/Essentials/samples/Samples/Essentials.Sample.csproj::TargetFramework=net9.0-ios]
2024-11-25T15:21:05.5809080Z /Users/builder/azdo/_work/3/s/.dotnet/packs/Microsoft.iOS.Sdk.net9.0_18.0/18.0.9617/tools/msbuild/iOS/Xamarin.Shared.targets(1836,3): error :          [/Users/builder/azdo/_work/3/s/src/Essentials/samples/Samples/Essentials.Sample.csproj::TargetFramework=net9.0-ios]
2024-11-25T15:21:05.5810110Z /Users/builder/azdo/_work/3/s/.dotnet/packs/Microsoft.iOS.Sdk.net9.0_18.0/18.0.9617/tools/msbuild/iOS/Xamarin.Shared.targets(1836,3): error : Could not find any available provisioning profiles for Microsoft.Maui.Graphics.DeviceTests on iOS. [/Users/builder/azdo/_work/3/s/src/Graphics/tests/DeviceTests/Graphics.DeviceTests.csproj::TargetFramework=net9.0-ios]
2024-11-25T15:21:05.5811090Z /Users/builder/azdo/_work/3/s/.dotnet/packs/Microsoft.iOS.Sdk.net9.0_18.0/18.0.9617/tools/msbuild/iOS/Xamarin.Shared.targets(1836,3): error :          [/Users/builder/azdo/_work/3/s/src/Graphics/tests/DeviceTests/Graphics.DeviceTests.csproj::TargetFramework=net9.0-ios]
2024-11-25T15:21:05.5811610Z     5460 Warning(s)
2024-11-25T15:21:05.5811880Z     3 Error(s)

@moljac
Copy link
Contributor Author

moljac commented Nov 25, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@moljac
Copy link
Contributor Author

moljac commented Nov 26, 2024

CI errors:

2024-11-25T22:24:47.9553650Z   Failed Issue18896Test [10 s]
2024-11-25T22:24:47.9554560Z   Error Message:
2024-11-25T22:24:47.9555200Z    VisualTestUtils.VisualTestFailedException : 
2024-11-25T22:24:47.9555820Z Snapshot different than baseline: Issue18896Test.png (8.00% difference)
2024-11-25T22:24:47.9557150Z If the correct baseline has changed (this isn't a a bug), then update the baseline image.
2024-11-25T22:24:47.9557970Z See test attachment or download the build artifacts to get the new snapshot file.

@moljac
Copy link
Contributor Author

moljac commented Nov 26, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@moljac
Copy link
Contributor Author

moljac commented Dec 3, 2024

/rebase

@jfversluis jfversluis added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Dec 9, 2024
@moljac
Copy link
Contributor Author

moljac commented Dec 17, 2024

/rebase

1 similar comment
@moljac
Copy link
Contributor Author

moljac commented Jan 6, 2025

/rebase

@moljac
Copy link
Contributor Author

moljac commented Jan 6, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen added this to the .NET 9 SR5 milestone Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattleibow mattleibow mattleibow left review comments

@rmarinho rmarinho Awaiting requested review from rmarinho rmarinho is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

@Redth Redth

@mattleibow mattleibow

@rmarinho rmarinho

@moljac moljac

Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions
Projects
MAUI SDK Ongoing
Status: Todo
Milestone
.NET 9 SR5
Development

Successfully merging this pull request may close these issues.
6 participants
@moljac @mattleibow @rmarinho @Redth @jfversluis @PureWeen