Make MauiAppCompatEditText public & adapt EntryHandler #26121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
requested changes
Nov 26, 2024
jsuarezruiz
reviewed
Nov 26, 2024
PureWeen
reviewed
Nov 27, 2024
| // TODO: NET8 issoto - Change the TPlatformView generic type to MauiAppCompatEditText | ||
| // This type adds support to the SelectionChanged event | ||
| public partial class EditorHandler : ViewHandler<IEditor, AppCompatEditText> | ||
| public partial class EditorHandler : ViewHandler<IEditor, MauiAppCompatEditText> |
There was a problem hiding this comment.
We can't change the generic type.
I think the only change here we can look at doing is making MauiAppCompatEditText public
I realize that makes the handler a little confusing :-/
But it'll be too breaking to change the generic type
|
Closing in favor of #26146 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This change makes
MauiAppCompatEditTextpublic and makes the necessary changes to the AndroidEntryHandleraccordingly.This was triggered by #25728 because people had no way to implement the workaround probably because
MauiAppCompatEditTextcould not be reached. Also there were a couple of TODOs in code to make this change.